linux-kernel - Re: [PATCH v2] fs: rename S_KERNEL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b0870835-58a6-39bb-2640-4595217999f0@nvidia.com>
Date:   Fri, 28 Jan 2022 09:01:00 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Christoph Hellwig <hch@....de>,
        "torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
        "viro@...iv.linux.org.uk" <viro@...iv.linux.org.uk>,
        "dhowells@...hat.com" <dhowells@...hat.com>
CC:     "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Amir Goldstein <amir73il@...il.com>
Subject: Re: [PATCH v2] fs: rename S_KERNEL_FILE

On 1/27/22 11:47 PM, Christoph Hellwig wrote:
> S_KERNEL_FILE is grossly misnamed.  We have plenty of files hold open by
> the kernel kernel using filp_open.  This flag OTOH signals the inode as
> being a special snowflake that cachefiles holds onto that can't be
> unlinked because of ..., erm, pixie dust.  So clearly mark it as such.
> 
> Signed-off-by: Christoph Hellwig <hch@....de>
> Reviewed-by: Amir Goldstein <amir73il@...il.com>
> ---
>

Looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>