linux-kernel - Re: [PATCH] block: fix boolreturn.cocci warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4c3e0a8f-5c53-6978-420c-cac0701fb0dc@nvidia.com>
Date:   Fri, 28 Jan 2022 09:10:09 +0000
From:   Chaitanya Kulkarni <chaitanyak@...dia.com>
To:     Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>,
        "axboe@...nel.dk" <axboe@...nel.dk>
CC:     "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Abaci Robot <abaci@...ux.alibaba.com>
Subject: Re: [PATCH] block: fix boolreturn.cocci warning

On 1/27/22 8:34 PM, Jiapeng Chong wrote:
> External email: Use caution opening links or attachments
> 
> 
> Return statements in functions returning bool should use true/false
> instead of 1/0.
> 
> ./block/bio.c:1081:9-10: WARNING: return of 0/1 in function
> 'bio_add_folio' with return type bool.
> 
> Reported-by: Abaci Robot <abaci@...ux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@...ux.alibaba.com>
> ---

Good catch, looks good.

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>