[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <YfO5dLsrdRlN7D62@krava>
Date: Fri, 28 Jan 2022 10:37:56 +0100
From: Jiri Olsa <jolsa@...hat.com>
To: Masami Hiramatsu <mhiramat@...nel.org>
Cc: Steven Rostedt <rostedt@...dmis.org>,
Alexei Starovoitov <ast@...nel.org>,
Daniel Borkmann <daniel@...earbox.net>,
Andrii Nakryiko <andrii@...nel.org>, netdev@...r.kernel.org,
bpf@...r.kernel.org, lkml <linux-kernel@...r.kernel.org>,
Martin KaFai Lau <kafai@...com>,
Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>,
John Fastabend <john.fastabend@...il.com>,
KP Singh <kpsingh@...omium.org>,
"Naveen N . Rao" <naveen.n.rao@...ux.ibm.com>,
Anil S Keshavamurthy <anil.s.keshavamurthy@...el.com>,
"David S . Miller" <davem@...emloft.net>
Subject: Re: [PATCH v5 1/9] ftrace: Add ftrace_set_filter_ips function
On Fri, Jan 28, 2022 at 11:05:23AM +0900, Masami Hiramatsu wrote:
SNIP
>
> So, I wrote a below change for the next version. Is that OK for you?
>
> Thank you,
>
> diff --git a/kernel/trace/ftrace.c b/kernel/trace/ftrace.c
> index f305e18f699f..a28b1bdb234a 100644
> --- a/kernel/trace/ftrace.c
> +++ b/kernel/trace/ftrace.c
> @@ -4985,8 +4985,13 @@ ftrace_match_addr(struct ftrace_hash *hash, unsigned long *ips,
>
> for (i = 0; i < cnt; i++) {
> err = __ftrace_match_addr(hash, ips[i], remove);
> - if (err)
> + if (err) {
> + /*
> + * This expects the @hash is a temporary hash and if this
> + * fails the caller must free the @hash.
> + */
> return err;
> + }
> }
> return 0;
> }
> @@ -5649,7 +5654,7 @@ int ftrace_set_filter_ip(struct ftrace_ops *ops, unsigned long ip,
> EXPORT_SYMBOL_GPL(ftrace_set_filter_ip);
>
> /**
> - * ftrace_set_filter_ips - set a functions to filter on in ftrace by addresses
> + * ftrace_set_filter_ips - set functions to filter on in ftrace by addresses
> * @ops - the ops to set the filter with
> * @ips - the array of addresses to add to or remove from the filter.
> * @cnt - the number of addresses in @ips
looks good, thanks
jirka
Powered by blists - more mailing lists