linux-kernel - RE: [EXT] Re: [PATCH v2] crypto: octeontx2: fix NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 28 Jan 2022 11:19:08 +0000
From:   Shijith Thotton <sthotton@...vell.com>
To:     Herbert Xu <herbert@...dor.apana.org.au>
CC:     "arno@...isbad.org" <arno@...isbad.org>,
        "bbrezillon@...nel.org" <bbrezillon@...nel.org>,
        "linux-crypto@...r.kernel.org" <linux-crypto@...r.kernel.org>,
        Jerin Jacob Kollanukkaran <jerinj@...vell.com>,
        Sunil Kovvuri Goutham <sgoutham@...vell.com>,
        Srujana Challa <schalla@...vell.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "chi.minghao@....com.cn" <chi.minghao@....com.cn>,
        "ovidiu.panait@...driver.com" <ovidiu.panait@...driver.com>,
        Suheil Chandran <schandran@...vell.com>,
        "Lukas Bartosik [C]" <lbartosik@...vell.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [EXT] Re: [PATCH v2] crypto: octeontx2: fix NULL pointer
 dereference

>> diff --git a/drivers/crypto/marvell/octeontx2/otx2_cptvf_algs.c
>b/drivers/crypto/marvell/octeontx2/otx2_cptvf_algs.c
>> index 2748a3327e39..620fa9b23e78 100644
>> --- a/drivers/crypto/marvell/octeontx2/otx2_cptvf_algs.c
>> +++ b/drivers/crypto/marvell/octeontx2/otx2_cptvf_algs.c
>> @@ -1650,7 +1650,7 @@ static inline int cpt_register_algs(void)
>>
>>        err = crypto_register_aeads(otx2_cpt_aeads,
>>                                    ARRAY_SIZE(otx2_cpt_aeads));
>> -       if (err) {
>> +       if (err && !IS_ENABLED(CONFIG_DM_CRYPT)) {
>>                crypto_unregister_skciphers(otx2_cpt_skciphers,
>>                                            ARRAY_SIZE(otx2_cpt_skciphers));
>>                return err;
>
>A better fix would be to make the driver actually work with
>dm-crypt.  What exactly is the issue?
>
>Even if we have to keep the kludge, please move this into Kconfig
>as a dependency and simply disable the whole driver.
>

I have tested the latest driver with dm-crypt and found no issues.
I will send next version without the checks.

Thanks,
Shijith