linux-kernel - Re: [PATCH v10] net: bonding: Add support for IPV6 ns/na to balance-alb/balance-tlb mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <85c5f9d7-ac78-509e-a1c4-4cb86544f423@chinatelecom.cn>
Date:   Fri, 28 Jan 2022 19:46:05 +0800
From:   孙守鑫 <sunshouxin@...natelecom.cn>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     j.vosburgh@...il.com, vfalico@...il.com, andy@...yhouse.net,
        davem@...emloft.net, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, jay.vosburgh@...onical.com,
        nikolay@...dia.com, huyd12@...natelecom.cn
Subject: Re: [PATCH v10] net: bonding: Add support for IPV6 ns/na to
 balance-alb/balance-tlb mode


Thanks your comment, I'll adjust it and send out v11 soon.


在 2022/1/28 10:47, Jakub Kicinski 写道:
> On Tue, 25 Jan 2022 09:24:18 -0500 Sun Shouxin wrote:
>> +/* determine if the packet is NA or NS */
>> +static bool __alb_determine_nd(struct icmp6hdr *hdr)
>> +{
>> +	if (hdr->icmp6_type == NDISC_NEIGHBOUR_ADVERTISEMENT ||
>> +	    hdr->icmp6_type == NDISC_NEIGHBOUR_SOLICITATION) {
>> +		return true;
>> +	}
>> +
>> +	return false;
>> +}
>> +
>> +static bool alb_determine_nd(struct sk_buff *skb, struct bonding *bond)
>> +{
>> +	struct ipv6hdr *ip6hdr;
>> +	struct icmp6hdr *hdr;
>> +
>> +	if (!pskb_network_may_pull(skb, sizeof(*ip6hdr)))
>> +		return true;
>> +
>> +	ip6hdr = ipv6_hdr(skb);
>> +	if (ip6hdr->nexthdr == IPPROTO_ICMPV6) {
> 	if (ip6hdr->nexthdr != IPPROTO_ICMPV6)
> 		return false;
>
> This way there's no need to indent the rest of the function.
>
>> +		if (!pskb_may_pull(skb, sizeof(*ip6hdr) + sizeof(*hdr)))
> What happened to the _network part? pskb_network_may_pull(), right?
>
>> +			return true;
>> +
>> +		hdr = icmp6_hdr(skb);
>> +		return __alb_determine_nd(hdr);
> Why create a full helper for this condition? Why not just:
>
> 	return hdr->icmp6_type == NDISC_NEIGHBOUR_ADVERTISEMENT ||
> 	       hdr->icmp6_type == NDISC_NEIGHBOUR_SOLICITATION;
>
>
>> +	}
>> +
>> +	return false;
>> +}