linux-kernel - Re: [PATCH v2] iwlwifi: dvm: use struct

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9fde441c79a6f08ef3c99ded93a00d7bb15c9ac6.camel@intel.com>
Date:   Fri, 28 Jan 2022 12:34:10 +0000
From:   "Coelho, Luciano" <luciano.coelho@...el.com>
To:     "kvalo@...nel.org" <kvalo@...nel.org>,
        "cgel.zte@...il.com" <cgel.zte@...il.com>
CC:     "zealci@....com.cn" <zealci@....com.cn>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "Berg, Johannes" <johannes.berg@...el.com>,
        "chi.minghao@....com.cn" <chi.minghao@....com.cn>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "trix@...hat.com" <trix@...hat.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH v2] iwlwifi: dvm: use struct_size over open coded
 arithmetic

On Fri, 2022-01-28 at 09:31 +0000, cgel.zte@...il.com wrote:
> From: Minghao Chi (CGEL ZTE) <chi.minghao@....com.cn>
> 
> Replace zero-length array with flexible-array member and make use
> of the struct_size() helper in kmalloc(). For example:

You're not replacing zero-length arrays in this patch, so this is not
correct.  Probably a copy/paste from a different patch?

--
Cheers,
Luca.