linux-kernel - Re: [RFC PATCH v2 1/5] perf stat: Implement --topdown with metrics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <70433fdc-831e-8afa-68c3-6d75a4f8c75a@huawei.com>
Date:   Fri, 28 Jan 2022 13:44:08 +0000
From:   John Garry <john.garry@...wei.com>
To:     Andrew Kilroy <andrew.kilroy@....com>,
        <linux-kernel@...r.kernel.org>, <linux-perf-users@...r.kernel.org>,
        <acme@...nel.org>, <irogers@...gle.com>, <ak@...ux.intel.com>
CC:     Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...hat.com>,
        "Namhyung Kim" <namhyung@...nel.org>
Subject: Re: [RFC PATCH v2 1/5] perf stat: Implement --topdown with metrics

On 11/01/2022 15:07, Andrew Kilroy wrote:
>   }
> +
> +bool topdown_can_use_json_metrics(void)

nit: maybe topdown_can_use_metricgroups() could be better

> +{
> +#if defined(__aarch64__)
> +	return true;
> +#else
> +	return false;
> +#endif

it might be worth just having !x86, just that is prob too much forward 
looking

> +}
> +