linux-kernel - Re: [PATCH v3] iio: humidity: hdc100x: Add ACPI HID table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VfC873djcc4Z2+HhzR8z3Uaute3g0Fgr1dvOs_v=gD3Lw@mail.gmail.com>
Date:   Fri, 28 Jan 2022 15:53:11 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Matt Ranostay <matt.ranostay@...sulko.com>,
        Your Name <you@...mple.com>,
        Chris Lesiak <chris.lesiak@...or.com>,
        linux-iio <linux-iio@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3] iio: humidity: hdc100x: Add ACPI HID table

On Fri, Jan 28, 2022 at 6:21 AM Kai-Heng Feng
<kai.heng.feng@...onical.com> wrote:
>
> x86 boards may use ACPI HID "TXNW1010" for the hdc100x device.
>
> TI told us "The ACPI ID for TI is: https://uefi.org/node/1028 (TXNW),
> therefore it would most likely be appropriate to use TXNW1010."

So, they basically agree on using it, did I get it right?

> So add an ACPI match table for that accordingly.

Assuming TI is aware of the ID,
Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>

> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
> ---
> v3:
>  - Add info from vendor
>  - Drop redundant line and comma.
>  - Wording change.
>
> v2:
>  - Change the ID to follow ACPI Spec
>  - Add __maybe_unused to avoid compiler warning
>
>  drivers/iio/humidity/hdc100x.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/iio/humidity/hdc100x.c b/drivers/iio/humidity/hdc100x.c
> index 9e0fce917ce4c..47f8e8ef56d68 100644
> --- a/drivers/iio/humidity/hdc100x.c
> +++ b/drivers/iio/humidity/hdc100x.c
> @@ -417,10 +417,17 @@ static const struct of_device_id hdc100x_dt_ids[] = {
>  };
>  MODULE_DEVICE_TABLE(of, hdc100x_dt_ids);
>
> +static const struct acpi_device_id hdc100x_acpi_match[] = {
> +       { "TXNW1010" },
> +       { }
> +};
> +MODULE_DEVICE_TABLE(acpi, hdc100x_acpi_match);
> +
>  static struct i2c_driver hdc100x_driver = {
>         .driver = {
>                 .name   = "hdc100x",
>                 .of_match_table = hdc100x_dt_ids,
> +               .acpi_match_table = hdc100x_acpi_match,
>         },
>         .probe = hdc100x_probe,
>         .id_table = hdc100x_id,
> --
> 2.33.1
>


-- 
With Best Regards,
Andy Shevchenko