linux-kernel - Re: [PATCH v2] Input: adxl34x: Add ACPI HID table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75Vcz01FwHUF5NAUhn4mfTgzoHBMEBkqPbfPHU=tNr_9Zdw@mail.gmail.com>
Date:   Fri, 28 Jan 2022 16:01:42 +0200
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Kai-Heng Feng <kai.heng.feng@...onical.com>
Cc:     Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        linux-input <linux-input@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] Input: adxl34x: Add ACPI HID table

On Fri, Jan 28, 2022 at 7:56 AM Kai-Heng Feng
<kai.heng.feng@...onical.com> wrote:
>
> x86 boards may use ACPI HID "ADS0345" for adxl34x device.

the adxl34x

> Analog replied:
> "ADS034X is not a valid PNP ID. ADS0345 would be.
> I'm not aware that this ID is already taken.
> Feel free to submit a mainline Linux input mailing list patch."
>
> So add an ACPI match table for that accordingly.

Reviewed-by: Andy Shevchenko <andy.shevchenko@...il.com>
Thanks!

> Signed-off-by: Kai-Heng Feng <kai.heng.feng@...onical.com>
> ---
> v2:
>  - Drop ACPI_PTR()
>  - Drop redundant empty line and comma
>  - Add info from vendor
>
>  drivers/input/misc/adxl34x-i2c.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/input/misc/adxl34x-i2c.c b/drivers/input/misc/adxl34x-i2c.c
> index a3b5f88d2bd16..b9af581cde800 100644
> --- a/drivers/input/misc/adxl34x-i2c.c
> +++ b/drivers/input/misc/adxl34x-i2c.c
> @@ -155,11 +155,18 @@ static const struct of_device_id adxl34x_of_id[] = {
>
>  MODULE_DEVICE_TABLE(of, adxl34x_of_id);
>
> +static const struct acpi_device_id adxl34x_acpi_match[] = {
> +       { "ADS0345" },
> +       { }
> +};
> +MODULE_DEVICE_TABLE(acpi, adxl34x_acpi_match);
> +
>  static struct i2c_driver adxl34x_driver = {
>         .driver = {
>                 .name = "adxl34x",
>                 .pm = &adxl34x_i2c_pm,
>                 .of_match_table = adxl34x_of_id,
> +               .acpi_match_table = adxl34x_acpi_match,
>         },
>         .probe    = adxl34x_i2c_probe,
>         .remove   = adxl34x_i2c_remove,
> --
> 2.33.1
>


-- 
With Best Regards,
Andy Shevchenko