linux-kernel - Re: [PATCH] Revert "pinctrl: zynqmp: Unify pin naming"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YfQCgnmyMOvB0V/k@smile.fi.intel.com>
Date:   Fri, 28 Jan 2022 16:49:38 +0200
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Gerhard Engleder <gerhard@...leder-embedded.com>
Cc:     linus.walleij@...aro.org, michal.simek@...inx.com,
        linux-gpio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Revert "pinctrl: zynqmp: Unify pin naming"

On Fri, Jan 28, 2022 at 04:45:14PM +0200, Andy Shevchenko wrote:
> On Thu, Jan 27, 2022 at 08:46:02PM +0100, Gerhard Engleder wrote:
> > From: Gerhard Engleder <gerhard@...leder-embedded.com>
> 
> Thanks for your report, my comments below.
> 
> > This reverts commit 54784ff24971ed5bd3f1056edce998148709d0a7.
> > 
> > This patch changes the pin names from "MIO%d" to "MIO-%d", but all dts
> > in arch/arm64/boot/dts/xilinx still use the old name. As a result my
> > ZCU104 has no output on serial terminal and is not reachable over
> > network.
> 
> And question here again, is the pin names ABI or not?
> If it's an ABI, then it should be clarified in the documentation.
> Otherwise, I'm wondering how this even may break anything.

Meanwhile I apply this to my tree and send as fix PR to Linus.

-- 
With Best Regards,
Andy Shevchenko