linux-kernel - Re: [PATCH] spi: uniphier: fix reference count leak in uniphier_spi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <164338554302.1711475.9019138910301906036.b4-ty@kernel.org>
Date:   Fri, 28 Jan 2022 15:59:03 +0000
From:   Mark Brown <broonie@...nel.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>,
        linux-kernel@...r.kernel.org, Xin Xiong <xiongx18@...an.edu.cn>,
        Kunihiko Hayashi <hayashi.kunihiko@...ionext.com>,
        linux-arm-kernel@...ts.infradead.org, linux-spi@...r.kernel.org
Cc:     Xin Tan <tanxin.ctf@...il.com>,
        Xiyu Yang <xiyuyang19@...an.edu.cn>, yuanxzhang@...an.edu.cn
Subject: Re: [PATCH] spi: uniphier: fix reference count leak in uniphier_spi_probe()

On Tue, 25 Jan 2022 18:12:15 +0800, Xin Xiong wrote:
> The issue happens in several error paths in uniphier_spi_probe().
> When either dma_get_slave_caps() or devm_spi_register_master() returns
> an error code, the function forgets to decrease the refcount of both
> `dma_rx` and `dma_tx` objects, which may lead to refcount leaks.
> 
> Fix it by decrementing the reference count of specific objects in
> those error paths.
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-linus

Thanks!

[1/1] spi: uniphier: fix reference count leak in uniphier_spi_probe()
      commit: 37c2c83ca4f1ef4b6908181ac98e18360af89b42

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark