[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a72131dea70845bd7741d7e9f4d49671d538aa79.camel@linux.ibm.com>
Date: Fri, 28 Jan 2022 11:03:38 -0500
From: Mimi Zohar <zohar@...ux.ibm.com>
To: Stefan Berger <stefanb@...ux.ibm.com>,
Stefan Berger <stefanb@...ux.vnet.ibm.com>,
linux-integrity@...r.kernel.org
Cc: serge@...lyn.com, christian.brauner@...ntu.com,
containers@...ts.linux.dev, dmitry.kasatkin@...il.com,
ebiederm@...ssion.com, krzysztof.struczynski@...wei.com,
roberto.sassu@...wei.com, mpeters@...hat.com, lhinds@...hat.com,
lsturman@...hat.com, puiterwi@...hat.com, jejb@...ux.ibm.com,
jamjoom@...ibm.com, linux-kernel@...r.kernel.org,
paul@...l-moore.com, rgb@...hat.com,
linux-security-module@...r.kernel.org, jmorris@...ei.org
Subject: Re: [PATCH v9 09/23] ima: Move some IMA policy and filesystem
related variables into ima_namespace
On Fri, 2022-01-28 at 10:44 -0500, Stefan Berger wrote:
> On 1/27/22 17:30, Mimi Zohar wrote:
> > On Tue, 2022-01-25 at 17:46 -0500, Stefan Berger wrote:
> >> From: Stefan Berger <stefanb@...ux.ibm.com>
> >>
> >> Move the ima_write_mutex, ima_fs_flag, and valid_policy variables into
> >> ima_namespace. This way each IMA namespace can set those variables
> >> independently.
> > This patch description needs to be expanded a bit, indicating why
> > they're being moved together. These flags are needed when loading a
> > policy. Please also update the "struct ima_namespace" comment.
>
> I'll extend the above sentence like this:
>
> ... those variables independently in its instance of securityfs.
That doesn't explain anything as to what these flags are or how they're
used. Perhaps something like, "Move the variables - ima_write_mutex,
ima_fs_flag, and valid_policy - related to updating the IMA policy into
the ima_namespace. This way each IMA namespace can set these variables
independently."
Did you notice my comment inline below?
thanks,
Mimi
Powered by blists - more mailing lists