linux-kernel - [PATCH] dmaengine: mmp_tdma: Add missing IRQ check in mmp_tdma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Fri, 28 Jan 2022 16:23:56 +0000
From:   Miaoqian Lin <linmq006@...il.com>
To:     Vinod Koul <vkoul@...nel.org>, Arnd Bergmann <arnd@...db.de>,
        Zhangfei Gao <zhangfei.gao@...vell.com>,
        dmaengine@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     linmq006@...il.com
Subject: [PATCH] dmaengine: mmp_tdma: Add missing IRQ check in mmp_tdma_probe

This func misses checking for  platform_get_irq()'s call and may passes
the negative error codes to devm_request_irq(), which takes unsigned IRQ #,
causing it to fail with -EINVAL, overriding an original error code.
Stop calling devm_request_irq() with invalid IRQ #s.

Fixes: f1a7757008b8 ("dmaengine: mmp_tdma: add dt support")
Signed-off-by: Miaoqian Lin <linmq006@...il.com>
---
 drivers/dma/mmp_tdma.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/dma/mmp_tdma.c b/drivers/dma/mmp_tdma.c
index a262e0eb4cc9..68f533ff7711 100644
--- a/drivers/dma/mmp_tdma.c
+++ b/drivers/dma/mmp_tdma.c
@@ -681,6 +681,8 @@ static int mmp_tdma_probe(struct platform_device *pdev)
 
 	if (irq_num != chan_num) {
 		irq = platform_get_irq(pdev, 0);
+		if (irq < 0)
+			return irq;
 		ret = devm_request_irq(&pdev->dev, irq,
 			mmp_tdma_int_handler, IRQF_SHARED, "tdma", tdev);
 		if (ret)
-- 
2.17.1