linux-kernel - Re: [PATCH V8 11/44] mm/pkeys: Define static PKS key array and default values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f2d05862-9750-fd19-42c0-29aa06bdeb13@intel.com>
Date:   Fri, 28 Jan 2022 16:02:05 -0800
From:   Dave Hansen <dave.hansen@...el.com>
To:     ira.weiny@...el.com, Dave Hansen <dave.hansen@...ux.intel.com>,
        "H. Peter Anvin" <hpa@...or.com>,
        Dan Williams <dan.j.williams@...el.com>
Cc:     Fenghua Yu <fenghua.yu@...el.com>,
        Rick Edgecombe <rick.p.edgecombe@...el.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH V8 11/44] mm/pkeys: Define static PKS key array and
 default values

On 1/27/22 09:54, ira.weiny@...el.com wrote:
> +#define PKS_INIT_VALUE (PKR_RW_KEY(PKS_KEY_DEFAULT)		| \
> +			PKR_AD_KEY(1)	| \
> +			PKR_AD_KEY(2)	| PKR_AD_KEY(3)		| \
> +			PKR_AD_KEY(4)	| PKR_AD_KEY(5)		| \
> +			PKR_AD_KEY(6)	| PKR_AD_KEY(7)		| \
> +			PKR_AD_KEY(8)	| PKR_AD_KEY(9)		| \
> +			PKR_AD_KEY(10)	| PKR_AD_KEY(11)	| \
> +			PKR_AD_KEY(12)	| PKR_AD_KEY(13)	| \
> +			PKR_AD_KEY(14)	| PKR_AD_KEY(15))

Considering how this is going to get used, let's just make this
one-key-per-line:

#define PKS_INIT_VALUE (PKR_RW_KEY(PKS_KEY_DEFAULT)		| \
			PKR_AD_KEY(1)	| \
			PKR_AD_KEY(2)	| \
			PKR_AD_KEY(3)	| \
			...