linux-kernel - Re: [PATCH v2] net: ena: Do not waste napi skb cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YfUA+vdxF/S+0/SB@ip-172-31-19-208.ap-northeast-1.compute.internal>
Date:   Sat, 29 Jan 2022 08:55:22 +0000
From:   Hyeonggon Yoo <42.hyeyoo@...il.com>
To:     Jakub Kicinski <kuba@...nel.org>
Cc:     jwiedmann.dev@...il.com, Shay Agroskin <shayagr@...zon.com>,
        Arthur Kiyanovski <akiyano@...zon.com>,
        David Arinzon <darinzon@...zon.com>,
        Noam Dagan <ndagan@...zon.com>,
        Saeed Bishara <saeedb@...zon.com>,
        "David S . Miller" <davem@...emloft.net>,
        Daniel Borkmann <daniel@...earbox.net>,
        Sameeh Jubran <sameehj@...zon.com>,
        Wei Yongjun <weiyongjun1@...wei.com>,
        Lorenzo Bianconi <lorenzo@...nel.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] net: ena: Do not waste napi skb cache

On Wed, Jan 26, 2022 at 07:52:20AM -0800, Jakub Kicinski wrote:
> On Wed, 26 Jan 2022 13:16:41 +0000 Hyeonggon Yoo wrote:
> > By profiling, discovered that ena device driver allocates skb by
> > build_skb() and frees by napi_skb_cache_put(). Because the driver
> > does not use napi skb cache in allocation path, napi skb cache is
> > periodically filled and flushed. This is waste of napi skb cache.
> > 
> > As ena_alloc_skb() is called only in napi, Use napi_build_skb()
> > and napi_alloc_skb() when allocating skb.
> > 
> > This patch was tested on aws a1.metal instance.
> > 
> > [ jwiedmann.dev@...il.com: Use napi_alloc_skb() instead of
> >   netdev_alloc_skb_ip_align() to keep things consistent. ]
> > 
> > Signed-off-by: Hyeonggon Yoo <42.hyeyoo@...il.com>
> 
> It seems you missed CCing netdev@, you'll need to repost.
> You can keep the ack from Shay.

Oh my mistake. I did it. Thanks!

Hyeonggon