linux-kernel - [ardb:arm64-ro-page-tables-pkvm-v5.17 15/26] arch/arm64/kvm/hyp/nvhe/pgtable_protect.c:21:17: warning: suggest braces around empty body in an 'if' statement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <202201290900.iZd18OR6-lkp@intel.com>
Date:   Sat, 29 Jan 2022 10:00:01 +0800
From:   kernel test robot <lkp@...el.com>
To:     Ard Biesheuvel <ardb@...nel.org>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [ardb:arm64-ro-page-tables-pkvm-v5.17 15/26]
 arch/arm64/kvm/hyp/nvhe/pgtable_protect.c:21:17: warning: suggest braces
 around empty body in an 'if' statement

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git arm64-ro-page-tables-pkvm-v5.17
head:   b38f2df95cbf61e70bc32017da5318d1cb03e3e3
commit: fd08c6c28e7fe82f8ee86abb3d1a0e1dd8c704d8 [15/26] arm64: kvm: use HYP helpers to perform page table updates
config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20220129/202201290900.iZd18OR6-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git/commit/?id=fd08c6c28e7fe82f8ee86abb3d1a0e1dd8c704d8
        git remote add ardb git://git.kernel.org/pub/scm/linux/kernel/git/ardb/linux.git
        git fetch --no-tags ardb arm64-ro-page-tables-pkvm-v5.17
        git checkout fd08c6c28e7fe82f8ee86abb3d1a0e1dd8c704d8
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/kvm/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   arch/arm64/kvm/hyp/nvhe/pgtable_protect.c: In function 'inject_external_abort':
>> arch/arm64/kvm/hyp/nvhe/pgtable_protect.c:21:17: warning: suggest braces around empty body in an 'if' statement [-Wempty-body]
      21 |                 ; // TODO
         |                 ^


vim +/if +21 arch/arm64/kvm/hyp/nvhe/pgtable_protect.c

    15	
    16	static void inject_external_abort(struct kvm_cpu_context *host_ctxt)
    17	{
    18		struct kvm_vcpu *vcpu = host_ctxt->__hyp_running_vcpu;
    19	
    20		if (vcpu)
  > 21			; // TODO
    22	
    23		write_sysreg_el2(read_sysreg_el2(SYS_ELR) - 1, SYS_ELR);
    24	}
    25	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org