linux-kernel - Re: [PATCH v2 2/2] staging: pi433: add debugfs interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YfS17W10UTAKn3dc@mail.google.com>
Date:   Sat, 29 Jan 2022 16:35:09 +1300
From:   Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@...il.com>
To:     Greg KH <gregkh@...uxfoundation.org>
Cc:     realwakka@...il.com, linux-staging@...ts.linux.dev,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 2/2] staging: pi433: add debugfs interface

On Wed, Jan 26, 2022 at 01:03:03PM +0100, Greg KH wrote:
> 
> Breaks the build:
> 
> drivers/staging/pi433/pi433_if.c:1166:25: error: initialization of ‘int (*)(struct inode *, struct file *)’ from incompatible pointer type ‘ssize_t (*)(struct inode *, struct file *)’ {aka ‘long int (*)(struct inode *, struct file *)’} [-Werror=incompatible-pointer-types]
>  1166 |         .open =         pi433_debugfs_regs_open,
>       |                         ^~~~~~~~~~~~~~~~~~~~~~~
> 
> 

My apologies, I will be more careful next time. I must have missed
something out on my module-specific makefile. 

I will incorporate the changes that Dan Carpenter suggested and submit a
new version of this patch shortly.

thanks,

Paulo A.