linux-kernel - Re: [PATCH] pps: clients: gpio: Propagate return value from pps_gpio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 30 Jan 2022 10:35:17 +0100
From:   Rodolfo Giometti <giometti@...eenne.com>
To:     Robert Hancock <robert.hancock@...ian.com>,
        "andriy.shevchenko@...ux.intel.com" 
        <andriy.shevchenko@...ux.intel.com>
Cc:     "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "gregkh@...uxfoundation.org" <gregkh@...uxfoundation.org>,
        "rasm@...up.pt" <rasm@...up.pt>,
        "jamesnuss@...ometrics.ca" <jamesnuss@...ometrics.ca>
Subject: Re: [PATCH] pps: clients: gpio: Propagate return value from
 pps_gpio_probe

On 29/01/22 23:02, Robert Hancock wrote:
> On Thu, 2022-01-13 at 09:17 +0100, Rodolfo Giometti wrote:
>> On 12/01/22 22:07, Andy Shevchenko wrote:
>>> On Wed, Jan 12, 2022 at 02:52:14PM -0600, Robert Hancock wrote:
>>>> If the pps-gpio driver was probed prior to the GPIO device it uses, the
>>>> devm_gpiod_get call returned an -EPROBE_DEFER error, but pps_gpio_probe
>>>> replaced that error code with -EINVAL, causing the pps-gpio probe to
>>>> fail and not be retried later. Propagate the error return value so that
>>>> deferred probe works properly.
>>>
>>> FWIW,
>>> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
>>
>> Acked-by: Rodolfo Giometti <giometti@...eenne.com>
> 
> It's not entirely clear to me what tree PPS patches are supposed to go through.
> Seems like some recent ones have gone through char-misc? Not sure if someone
> has this in their queue?

LinuxPPS has no its own tree. All related patches usually are sent to me to be
acked and to Greg Kroah-Hartman for inclusion.

Ciao,

Rodolfo

-- 
GNU/Linux Solutions                  e-mail: giometti@...eenne.com
Linux Device Driver                          giometti@...ux.it
Embedded Systems                     phone:  +39 349 2432127
UNIX programming                     skype:  rodolfo.giometti