linux-kernel - Re: [PATCH V6 2/2] irqchip/sifive-plic: Fixup thead,c900-plic dt parse in opensbi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJF2gTROgAuj0j2qC6AZFgP+k3erU7erQRadH5ugaVPkj_=1hQ@mail.gmail.com>
Date:   Sun, 30 Jan 2022 23:11:44 +0800
From:   Guo Ren <guoren@...nel.org>
To:     Marc Zyngier <maz@...nel.org>
Cc:     Samuel Holland <samuel@...lland.org>,
        Anup Patel <anup@...infault.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Palmer Dabbelt <palmer@...belt.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        linux-riscv <linux-riscv@...ts.infradead.org>,
        devicetree <devicetree@...r.kernel.org>,
        Guo Ren <guoren@...ux.alibaba.com>
Subject: Re: [PATCH V6 2/2] irqchip/sifive-plic: Fixup thead,c900-plic dt
 parse in opensbi

On Sun, Jan 30, 2022 at 10:59 PM Marc Zyngier <maz@...nel.org> wrote:
>
> On Sun, 30 Jan 2022 13:09:21 +0000,
> Guo Ren <guoren@...nel.org> wrote:
> >
> > On Sun, Jan 30, 2022 at 6:28 PM Marc Zyngier <maz@...nel.org> wrote:
> > >
> > > On Sun, 30 Jan 2022 04:39:34 +0000,
> > > Guo Ren <guoren@...nel.org> wrote:
> > > >
> > > > > +IRQCHIP_DECLARE(thead_c900_plic, "thead,c900-plic", plic_init);
> > > > I think we should give clear info in /proc/interrupts. I hope we could
> > > > keep thead_plic_init.
> > >
> > > Why? There is no material difference at the driver level, and
> > > /proc/interrupts won't be the target of a branding exercise (which
> > > this series seems to be all about).
> > It's not a branding exercise, the series just correct the broken code
> > & incorrect /proc/interrupts display.
>
> There is *nothing* incorrect in /proc/interrupt. If anything, changing
> the string *is* an ABI change, for no good reason.
I've minimized the modification to fix the problem, please have a look:

https://lore.kernel.org/linux-riscv/20220130135634.1213301-3-guoren@kernel.org/T/#u

>
>         M.
>
> --
> Without deviation from the norm, progress is not possible.

--
Best Regards
 Guo Ren

ML: https://lore.kernel.org/linux-csky/