linux-kernel - Re: [PATCH v5 0/9] Add MAX77714 PMIC minimal driver (RTC and watchdog only)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7ea1d8ab-9d76-c19a-56c8-f66599534deb@roeck-us.net>
Date:   Sun, 30 Jan 2022 08:00:31 -0800
From:   Guenter Roeck <linux@...ck-us.net>
To:     Luca Ceresoli <luca@...aceresoli.net>,
        Lee Jones <lee.jones@...aro.org>
Cc:     linux-rtc@...r.kernel.org, linux-watchdog@...r.kernel.org,
        devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
        Chanwoo Choi <cw00.choi@...sung.com>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Wim Van Sebroeck <wim@...ux-watchdog.org>,
        Chiwoong Byun <woong.byun@...sung.com>,
        Laxman Dewangan <ldewangan@...dia.com>,
        Randy Dunlap <rdunlap@...radead.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 0/9] Add MAX77714 PMIC minimal driver (RTC and watchdog
 only)

On 1/30/22 04:45, Luca Ceresoli wrote:
> Hi Guenter,
> 
> On 30/01/22 02:48, Guenter Roeck wrote:
>> On 1/29/22 00:40, Luca Ceresoli wrote:
>>> Hi Lee, all,
>>>
>>> On 11/01/22 11:10, Luca Ceresoli wrote:
>>>> Hi All,
>>>>
>>>> On 11/12/21 18:59, Luca Ceresoli wrote:
>>>>> Hi,
>>>>>
>>>>> this series adds minimal drivers for the Maxim Semiconductor MAX77714
>>>>> (https://www.maximintegrated.com/en/products/power/power-management-ics/MAX77714.html).
>>>>>
>>>>> Only RTC and watchdog are implemented by these patches.
>>>>>
>>>>> All implemented functionality is tested and working: RTC read/write,
>>>>> watchdog start/stop/ping/set_timeout.
>>>>>
>>>>> Patches 1-3 + 6 are trivial cleanups to the max77686 drivers and
>>>>> Kconfig
>>>>> indentation and can probably be applied easily.
>>>>>
>>>>> Patches 4, 5, 7, 8 and 9 add: dt bindings, mfd driver, watchdog
>>>>> driver and
>>>>> rtc driver.
>>>>
>>>> A gentle ping about this series. It's at v5, all patches have at least
>>>> one ack/review tag and most patches are unchanged since ~v2. It applies
>>>> cleanly on current master.
>>>>
>>>> Is there anything I should do to help making progress?
>>>
>>> Apologies for pinging again... but as I got no further comments about
>>> these patches I guess I can really do nothing at the moment.
>>>
>>> Lee, is this series completely in charge to you or should it be applied
>>> by the respective subsystem maintainers?
>>>
>>
>> I hesitated to take the watchdog patches because an earlier patch of the
>> series
>> introduces MFD_MAX77714 and the watchdog Kconfig entry lists it as
>> dependency.
>> I now added patch 7/9 and 8/9 to my watchdog-next tree anyway. If the
>> mfd part
>> doesn't make it we can still decide to take it out at some point.
> 
> OK, thank you! In the meanwhile the kernel test robot also reported a
> build failure due to missing max77714.h file, which is added by patch 5.
> 

Yes, I noticed. Which means I'll have to drop the patch again, and we'll have
to wait for the mfd patch to land, sorry.

Guenter

>> Note that patch 6/9 has already been applied.
> 
> Indeed, it's in Linus' master already.
> 
> Regards.