linux-kernel - Re: [PATCH] fs: Remove FIXME comment in generic_write

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yfboax2Yw/s5xAnp@zeniv-ca.linux.org.uk>
Date:   Sun, 30 Jan 2022 19:35:07 +0000
From:   Al Viro <viro@...iv.linux.org.uk>
To:     Tal Zussman <tz2294@...umbia.edu>
Cc:     "open list:FILESYSTEMS (VFS and infrastructure)" 
        <linux-fsdevel@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Xijiao Li <xl2950@...umbia.edu>,
        Hans Montero <hjm2133@...umbia.edu>,
        Theodore Ts'o <tytso@....edu>,
        OS-TA <cucs4118-tas@...glegroups.com>
Subject: Re: [PATCH] fs: Remove FIXME comment in generic_write_checks()

On Fri, Dec 31, 2021 at 02:57:50AM -0500, Tal Zussman wrote:
> This patch removes an unnecessary comment that had to do with block special
> files from `generic_write_checks()`.
> 
> The comment, originally added in Linux v2.4.14.9, was to clarify that we only
> set `pos` to the file size when the file was opened with `O_APPEND` if the file
> wasn't a block special file. Prior to Linux v2.4, block special files had a
> different `write()` function which was unified into a generic `write()` function
> in Linux v2.4. This generic `write()` function called `generic_write_checks()`.
> For more details, see this earlier conversation:
> https://lore.kernel.org/linux-fsdevel/Yc4Czk5A+p5p2Y4W@mit.edu/
> 
> Currently, block special devices have their own `write_iter()` function and no
> longer share the same `generic_write_checks()`, therefore rendering the comment
> irrelevant.

Applied