Date:   Mon, 31 Jan 2022 06:28:34 +0800
From:   kernel test robot <lkp@...el.com>
To:     Aaron Conole <aconole@...hat.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Linux Memory Management List <linux-mm@...ck.org>,
        Sasha Levin <sashal@...nel.org>
Subject: [linux-stable-rc:linux-4.4.y 6439/9999]
 include/asm-generic/bug.h:159:2: error: implicit declaration of function
 'no_printk'; did you mean 'printk'?

Hi Aaron,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git linux-4.4.y
head:   26e2ad2acac73730fe99e6cfd43a2019b904d983
commit: b60b53d4980f879884740e672d83155980d74445 [6439/9999] printk: help pr_debug and pr_devel to optimize out arguments
config: h8300-randconfig-r026-20220130 (https://download.01.org/0day-ci/archive/20220131/202201310535.VmQma3Z4-lkp@intel.com/config)
compiler: h8300-linux-gcc (GCC) 7.5.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git/commit/?id=b60b53d4980f879884740e672d83155980d74445
        git remote add linux-stable-rc https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable-rc.git
        git fetch --no-tags linux-stable-rc linux-4.4.y
        git checkout b60b53d4980f879884740e672d83155980d74445
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-7.5.0 make.cross O=build_dir ARCH=h8300 SHELL=/bin/bash lib/842/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from lib/842/842_decompress.c:23:0:
   lib/842/842_debugfs.h: In function 'sw842_debugfs_create':
   lib/842/842_debugfs.h:27:16: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     for (i = 0; i < ARRAY_SIZE(template_count); i++) {
                   ^
   lib/842/842_decompress.c: In function 'next_bits':
   lib/842/842_decompress.c:115:28: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
     if (DIV_ROUND_UP(bits, 8) > p->ilen)
                               ^
   In file included from arch/h8300/include/asm/bug.h:7:0,
                    from include/linux/bug.h:4,
                    from include/linux/thread_info.h:11,
                    from include/asm-generic/preempt.h:4,
                    from arch/h8300/include/generated/asm/preempt.h:1,
                    from include/linux/preempt.h:59,
                    from include/linux/spinlock.h:50,
                    from include/linux/seqlock.h:35,
                    from include/linux/time.h:5,
                    from include/linux/stat.h:18,
                    from include/linux/module.h:10,
                    from lib/842/842.h:76,
                    from lib/842/842_decompress.c:22:
   lib/842/842_decompress.c: In function '__do_index':
>> include/asm-generic/bug.h:159:2: error: implicit declaration of function 'no_printk'; did you mean 'printk'? [-Werror=implicit-function-declaration]
     no_printk(format);      \
     ^
   lib/842/842_decompress.c:72:3: note: in expansion of macro 'WARN'
      WARN(1, "pr_debug param err invalid size %x\n", s))
      ^~~~
   include/linux/printk.h:114:17: note: in expansion of macro 'beN_to_cpu'
      printk(fmt, ##__VA_ARGS__); \
                    ^~~~~~~~~~~
   include/linux/printk.h:289:2: note: in expansion of macro 'no_printk'
     no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
     ^~~~~~~~~
   lib/842/842_decompress.c:205:2: note: in expansion of macro 'pr_debug'
     pr_debug("index%x to %lx off %lx adjoff %lx tot %lx data %lx\n",
     ^~~~~~~~
   lib/842/842_decompress.c:71:54: warning: signed and unsigned type in conditional expression [-Wsign-compare]
      (s) == 8 ? be64_to_cpu(get_unaligned((__be64 *)d)) : \
                                                         ^
   include/linux/printk.h:114:17: note: in expansion of macro 'beN_to_cpu'
      printk(fmt, ##__VA_ARGS__); \
                    ^~~~~~~~~~~
   include/linux/printk.h:289:2: note: in expansion of macro 'no_printk'
     no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
     ^~~~~~~~~
   lib/842/842_decompress.c:205:2: note: in expansion of macro 'pr_debug'
     pr_debug("index%x to %lx off %lx adjoff %lx tot %lx data %lx\n",
     ^~~~~~~~
   cc1: some warnings being treated as errors


vim +159 include/asm-generic/bug.h

b607e70ec6a982 Josh Triplett 2014-04-07  155  
b607e70ec6a982 Josh Triplett 2014-04-07  156  #ifndef WARN
b607e70ec6a982 Josh Triplett 2014-04-07  157  #define WARN(condition, format...) ({					\
b607e70ec6a982 Josh Triplett 2014-04-07  158  	int __ret_warn_on = !!(condition);				\
4e50ebde32bed6 Josh Triplett 2014-04-07 @159  	no_printk(format);						\
b607e70ec6a982 Josh Triplett 2014-04-07  160  	unlikely(__ret_warn_on);					\
b607e70ec6a982 Josh Triplett 2014-04-07  161  })
b607e70ec6a982 Josh Triplett 2014-04-07  162  #endif
b607e70ec6a982 Josh Triplett 2014-04-07  163  

:::::: The code at line 159 was first introduced by commit
:::::: 4e50ebde32bed67a9aec8c239bbd89e5d0b8727b bug: when !CONFIG_BUG, make WARN call no_printk to check format and args

:::::: TO: Josh Triplett <josh@...htriplett.org>
:::::: CC: Linus Torvalds <torvalds@...ux-foundation.org>

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

Powered by blists - more mailing lists