linux-kernel - Re: [PATCH] carl9170: fix missing bit-wise or operator for tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <164363847846.10147.1688492518810406694.kvalo@kernel.org>
Date:   Mon, 31 Jan 2022 14:14:39 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Colin Ian King <colin.i.king@...il.com>
Cc:     Christian Lamparter <chunkeey@...glemail.com>,
        "David S . Miller" <davem@...emloft.net>,
        Jakub Kicinski <kuba@...nel.org>,
        linux-wireless@...r.kernel.org, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        Stable@...r.kernel.org
Subject: Re: [PATCH] carl9170: fix missing bit-wise or operator for tx_params

Colin Ian King <colin.i.king@...il.com> wrote:

> Currently tx_params is being re-assigned with a new value and the
> previous setting IEEE80211_HT_MCS_TX_RX_DIFF is being overwritten.
> The assignment operator is incorrect, the original intent was to
> bit-wise or the value in. Fix this by replacing the = operator
> with |= instead.
> 
> Kudos to Christian Lamparter for suggesting the correct fix.
> 
> Fixes: fe8ee9ad80b2 ("carl9170: mac80211 glue and command interface")
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>
> Cc: <Stable@...r.kernel.org>
> Acked-by: Christian Lamparter <chunkeey@...il.com>
> Signed-off-by: Kalle Valo <quic_kvalo@...cinc.com>

Patch applied to ath-next branch of ath.git, thanks.

02a95374b5ee carl9170: fix missing bit-wise or operator for tx_params

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20220125004406.344422-1-colin.i.king@gmail.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches