| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <YffylboRjcfX9cz2@latitude>
Date: Mon, 31 Jan 2022 15:30:45 +0100
From: Jonathan Neuschäfer <j.neuschaefer@....net>
To: Joel Stanley <joel@....id.au>
Cc: Jonathan Neuschäfer <j.neuschaefer@....net>,
OpenBMC Maillist <openbmc@...ts.ozlabs.org>,
devicetree <devicetree@...r.kernel.org>,
Tomer Maimon <tmaimon77@...il.com>,
Avi Fishman <avifishman70@...il.com>,
Patrick Venture <venture@...gle.com>,
Tali Perry <tali.perry1@...il.com>,
Rob Herring <robh+dt@...nel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
Benjamin Fair <benjaminfair@...gle.com>
Subject: Re: [PATCH] ARM: dts: nuvoton, npcm7xx: remove bogus unit addresses
from fixed-partition nodes
On Mon, Jan 31, 2022 at 06:29:42AM +0000, Joel Stanley wrote:
> On Sat, 29 Jan 2022 at 09:32, Jonathan Neuschäfer <j.neuschaefer@....net> wrote:
> >
> > The unit addresses do not correspond to the nodes' reg properties,
> > because they don't have any.
> >
> > Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@....net>
>
> Reviewed-by: Joel Stanley <joel@....id.au>
>
> Do you want to add a Fixes: line?
Sounds reasonable, I'll add it.
Jonathan
>
> > ---
> > arch/arm/boot/dts/nuvoton-npcm730-gbs.dts | 2 +-
> > arch/arm/boot/dts/nuvoton-npcm730-gsj.dts | 2 +-
> > arch/arm/boot/dts/nuvoton-npcm730-kudo.dts | 6 +++---
> > arch/arm/boot/dts/nuvoton-npcm750-evb.dts | 4 ++--
> > arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts | 6 +++---
> > 5 files changed, 10 insertions(+), 10 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/nuvoton-npcm730-gbs.dts b/arch/arm/boot/dts/nuvoton-npcm730-gbs.dts
> > index eb6eb21cb2a44..33c8d5b3d679a 100644
> > --- a/arch/arm/boot/dts/nuvoton-npcm730-gbs.dts
> > +++ b/arch/arm/boot/dts/nuvoton-npcm730-gbs.dts
> > @@ -366,7 +366,7 @@ spi-nor@0 {
> > spi-max-frequency = <20000000>;
> > spi-rx-bus-width = <2>;
> > label = "bmc";
> > - partitions@...00000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > diff --git a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
> > index d4ff49939a3d9..bbe18618f5c56 100644
> > --- a/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
> > +++ b/arch/arm/boot/dts/nuvoton-npcm730-gsj.dts
> > @@ -142,7 +142,7 @@ spi-nor@0 {
> > reg = <0>;
> > spi-rx-bus-width = <2>;
> >
> > - partitions@...00000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > diff --git a/arch/arm/boot/dts/nuvoton-npcm730-kudo.dts b/arch/arm/boot/dts/nuvoton-npcm730-kudo.dts
> > index 82a104b2a65f1..8e3425cb8e8b9 100644
> > --- a/arch/arm/boot/dts/nuvoton-npcm730-kudo.dts
> > +++ b/arch/arm/boot/dts/nuvoton-npcm730-kudo.dts
> > @@ -388,7 +388,7 @@ spi-nor@0 {
> > spi-max-frequency = <5000000>;
> > spi-rx-bus-width = <2>;
> > label = "bmc";
> > - partitions@...00000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > @@ -422,7 +422,7 @@ spi-nor@1 {
> > reg = <1>;
> > spi-max-frequency = <5000000>;
> > spi-rx-bus-width = <2>;
> > - partitions@...00000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > @@ -447,7 +447,7 @@ spi-nor@0 {
> > reg = <0>;
> > spi-max-frequency = <5000000>;
> > spi-rx-bus-width = <2>;
> > - partitions@...00000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > diff --git a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> > index 0334641f88292..cf274c926711a 100644
> > --- a/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> > +++ b/arch/arm/boot/dts/nuvoton-npcm750-evb.dts
> > @@ -74,7 +74,7 @@ spi-nor@0 {
> > spi-rx-bus-width = <2>;
> > reg = <0>;
> > spi-max-frequency = <5000000>;
> > - partitions@...00000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > @@ -135,7 +135,7 @@ spi-nor@0 {
> > spi-rx-bus-width = <2>;
> > reg = <0>;
> > spi-max-frequency = <5000000>;
> > - partitions@...00000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > diff --git a/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts b/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts
> > index 767e0ac0df7c5..7fe7efee28acb 100644
> > --- a/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts
> > +++ b/arch/arm/boot/dts/nuvoton-npcm750-runbmc-olympus.dts
> > @@ -107,7 +107,7 @@ spi-nor@0 {
> > reg = <0>;
> > spi-rx-bus-width = <2>;
> >
> > - partitions@...00000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > @@ -146,7 +146,7 @@ spi-nor@1 {
> > reg = <1>;
> > npcm,fiu-rx-bus-width = <2>;
> >
> > - partitions@...00000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > @@ -173,7 +173,7 @@ spi-nor@0 {
> > reg = <0>;
> > spi-rx-bus-width = <2>;
> >
> > - partitions@...00000 {
> > + partitions {
> > compatible = "fixed-partitions";
> > #address-cells = <1>;
> > #size-cells = <1>;
> > --
> > 2.34.1
> >
Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)
Powered by blists - more mailing lists