lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 31 Jan 2022 17:13:45 +0200 From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>, Wolfram Sang <wsa@...nel.org>, Jean Delvare <jdelvare@...e.de>, Heiner Kallweit <hkallweit1@...il.com>, Lee Jones <lee.jones@...aro.org>, Hans de Goede <hdegoede@...hat.com>, Linus Walleij <linus.walleij@...aro.org>, Tan Jui Nee <jui.nee.tan@...el.com>, Kate Hsuan <hpa@...hat.com>, Jonathan Yong <jonathan.yong@...el.com>, linux-kernel@...r.kernel.org, linux-edac@...r.kernel.org, linux-i2c@...r.kernel.org, linux-gpio@...r.kernel.org, platform-driver-x86@...r.kernel.org Cc: Borislav Petkov <bp@...en8.de>, Mauro Carvalho Chehab <mchehab@...nel.org>, Tony Luck <tony.luck@...el.com>, James Morse <james.morse@....com>, Robert Richter <rric@...nel.org>, Jean Delvare <jdelvare@...e.com>, Peter Tyser <ptyser@...-inc.com>, Mika Westerberg <mika.westerberg@...ux.intel.com>, Andy Shevchenko <andy@...nel.org>, Mark Gross <markgross@...nel.org>, Henning Schild <henning.schild@...mens.com> Subject: [PATCH v4 7/8] EDAC, pnd2: Use proper I/O accessors and address space annotation The driver uses rather voodoo kind of castings and I/O accessors. Replace it with proper __iomem annotation and readl()/readq() calls. Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com> Reviewed-by: Tony Luck <tony.luck@...el.com> --- drivers/edac/pnd2_edac.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/edac/pnd2_edac.c b/drivers/edac/pnd2_edac.c index c94ca1f790c4..7d1df120e24c 100644 --- a/drivers/edac/pnd2_edac.c +++ b/drivers/edac/pnd2_edac.c @@ -265,7 +265,7 @@ static u64 get_sideband_reg_base_addr(void) static int dnv_rd_reg(int port, int off, int op, void *data, size_t sz, char *name) { struct pci_dev *pdev; - char *base; + void __iomem *base; u64 addr; unsigned long size; @@ -297,8 +297,9 @@ static int dnv_rd_reg(int port, int off, int op, void *data, size_t sz, char *na return -ENODEV; if (sz == 8) - *(u32 *)(data + 4) = *(u32 *)(base + off + 4); - *(u32 *)data = *(u32 *)(base + off); + *(u64 *)data = readq(base + off); + else + *(u32 *)data = readl(base + off); iounmap(base); } -- 2.34.1
Powered by blists - more mailing lists