linux-kernel - Re: [fs/exec] 80bd5afdd8: xfstests.generic.633.fail

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yff9+tIDAvYM5EO/@casper.infradead.org>
Date:   Mon, 31 Jan 2022 15:19:22 +0000
From:   Matthew Wilcox <willy@...radead.org>
To:     Christian Brauner <brauner@...nel.org>
Cc:     kernel test robot <oliver.sang@...el.com>,
        Kees Cook <keescook@...omium.org>,
        Ariadne Conill <ariadne@...eferenced.org>,
        0day robot <lkp@...el.com>,
        Michael Kerrisk <mtk.manpages@...il.com>,
        Rich Felker <dalias@...c.org>,
        Eric Biederman <ebiederm@...ssion.com>,
        Alexander Viro <viro@...iv.linux.org.uk>,
        LKML <linux-kernel@...r.kernel.org>, lkp@...ts.01.org,
        Andrew Morton <akpm@...ux-foundation.org>,
        linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
        stable@...r.kernel.org
Subject: Re: [fs/exec]  80bd5afdd8: xfstests.generic.633.fail

On Mon, Jan 31, 2022 at 04:08:19PM +0100, Christian Brauner wrote:
> On Mon, Jan 31, 2022 at 10:43:52PM +0800, kernel test robot wrote:
> I can fix this rather simply in our upstream fstests with:
> 
> static char *argv[] = {
> 	"",
> };
> 
> I guess.
> 
> But doesn't
> 
> static char *argv[] = {
> 	NULL,
> };
> 
> seem something that should work especially with execveat()?

The problem is that the exec'ed program sees an argc of 0, which is the
problem we're trying to work around in the kernel (instead of leaving
it to ld.so to fix for suid programs).