linux-kernel - Re: [PATCH] arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's DSI endpoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAG3jFytzxD9aAFGNhZ5djgqjgU7QmKOei077TYn7t3QpQdMb-g@mail.gmail.com>
Date:   Mon, 31 Jan 2022 17:17:39 +0100
From:   Robert Foss <robert.foss@...aro.org>
To:     AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
Cc:     Nícolas F. R. A. Prado 
        <nfraprado@...labora.com>, Rob Herring <robh+dt@...nel.org>,
        Matthias Brugger <matthias.bgg@...il.com>,
        Xin Ji <xji@...logixsemi.com>, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org,
        kernel@...labora.com
Subject: Re: [PATCH] arm64: dts: mt8183: jacuzzi: Fix bus properties in anx's
 DSI endpoint

Hey,

On Fri, 21 Jan 2022 at 12:46, AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com> wrote:
>
> Il 20/01/22 23:42, Nícolas F. R. A. Prado ha scritto:
> > mt8183-kukui-jacuzzi has an anx7625 bridge connected to the output of
> > its DSI host. However, after fd0310b6fe7d ("drm/bridge: anx7625: add
> > MIPI DPI input feature"), a bus-type property started being required in
> > the endpoint node by the driver to indicate whether it is DSI or DPI.
> >
> > Add the missing bus-type property and set it to 5
> > (V4L2_FWNODE_BUS_TYPE_PARALLEL) so that the driver has its input
> > configured to DSI and the display pipeline can probe correctly.
> >
> > While at it, also set the data-lanes property that was also introduced
> > in that same commit, so that we don't rely on the default value.
> >
> > Fixes: fd0310b6fe7d ("drm/bridge: anx7625: add MIPI DPI input feature")
> > Signed-off-by: Nícolas F. R. A. Prado <nfraprado@...labora.com>
>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
>
> > ---
> >   arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi | 2 ++
> >   1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> > index 8f7bf33f607d..e8f133dc96b9 100644
> > --- a/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> > +++ b/arch/arm64/boot/dts/mediatek/mt8183-kukui-jacuzzi.dtsi
> > @@ -171,6 +171,8 @@ port@0 {
> >
> >                       anx7625_in: endpoint {
> >                               remote-endpoint = <&dsi_out>;
> > +                             bus-type = <5>;
> > +                             data-lanes = <0 1 2 3>;
> >                       };
> >               };
> >
> >

This patch does not pass checkpatch --strict, please add the word
commit before the hash in the commit message to fix this.


Rob.