linux-kernel - Re: [PATCH v4] kselftest: Fix vdso_test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <299a9d32-ec50-029b-b8c7-b89aff6331a4@linuxfoundation.org>
Date:   Mon, 31 Jan 2022 10:37:54 -0700
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Vincenzo Frascino <vincenzo.frascino@....com>,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:     Shuah Khan <shuah@...nel.org>, Andy Lutomirski <luto@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Cristian Marussi <cristian.marussi@....com>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v4] kselftest: Fix vdso_test_abi return status

On 1/31/22 4:34 AM, Vincenzo Frascino wrote:
> vdso_test_abi contains a batch of tests that verify the validity of the
> vDSO ABI.
> 
> When a vDSO symbol is not found the relevant test is skipped reporting
> KSFT_SKIP. All the tests return values are then added in a single
> variable which is checked to verify failures. This approach can have
> side effects which result in reporting the wrong kselftest exit status.
> 
> Fix vdso_test_abi verifying the return code of each test separately.
> 
> Cc: Shuah Khan <shuah@...nel.org>
> Cc: Andy Lutomirski <luto@...nel.org>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Reported-by: Cristian Marussi <cristian.marussi@....com>
> Signed-off-by: Vincenzo Frascino <vincenzo.frascino@....com>
> ---
>   tools/testing/selftests/vDSO/vdso_test_abi.c | 135 +++++++++----------
>   1 file changed, 62 insertions(+), 73 deletions(-)
> 

Thank you. Applied to linux-kselftest fixes for rc3

thanks,
-- Shuah