linux-kernel - Re: [PATCH v4 39/66] binfmt_elf: Take the mmap lock when walking the VMA list

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220131174121.4swfexon5ezu7b4i@revolver>
Date:   Mon, 31 Jan 2022 17:41:27 +0000
From:   Liam Howlett <liam.howlett@...cle.com>
To:     Vlastimil Babka <vbabka@...e.cz>
CC:     "maple-tree@...ts.infradead.org" <maple-tree@...ts.infradead.org>,
        "linux-mm@...ck.org" <linux-mm@...ck.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Song Liu <songliubraving@...com>,
        Davidlohr Bueso <dave@...olabs.net>,
        "Paul E . McKenney" <paulmck@...nel.org>,
        Matthew Wilcox <willy@...radead.org>,
        Laurent Dufour <ldufour@...ux.ibm.com>,
        David Rientjes <rientjes@...gle.com>,
        Axel Rasmussen <axelrasmussen@...gle.com>,
        Suren Baghdasaryan <surenb@...gle.com>,
        Rik van Riel <riel@...riel.com>,
        Peter Zijlstra <peterz@...radead.org>,
        Michel Lespinasse <walken.cr@...il.com>,
        Jerome Glisse <jglisse@...hat.com>,
        Minchan Kim <minchan@...gle.com>,
        Joel Fernandes <joelaf@...gle.com>,
        Rom Lemarchand <romlem@...gle.com>
Subject: Re: [PATCH v4 39/66] binfmt_elf: Take the mmap lock when walking the
 VMA list

* Vlastimil Babka <vbabka@...e.cz> [220119 05:53]:
> On 12/1/21 15:30, Liam Howlett wrote:
> > From: "Matthew Wilcox (Oracle)" <willy@...radead.org>
> > 
> > I'm not sure if the VMA list can change under us, but dump_vma_snapshot()
> > is very careful to take the mmap_lock in write mode.  We only need to
> > take it in read mode here as we do not care if the size of the stack
> > VMA changes underneath us.
> > 
> > If it can be changed underneath us, this is a potential use-after-free
> > for a multithreaded process which is dumping core.
> > 
> > Fixes: 2aa362c49c31 ("coredump: extend core dump note section to contain file names of mapped files")
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@...radead.org>
> > Signed-off-by: Liam R. Howlett <Liam.Howlett@...cle.com>
> 
> To be honest this feels out of place in this series. Send separately and CC
> Jann who AFAICS added dump_vma_snapshot()?

Thanks.  I have moved the version Matthew sent out separately to the
start of my v5 set.

> 
> > ---
> >  fs/binfmt_elf.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c
> > index d41cca755ff9..5915518c8a1d 100644
> > --- a/fs/binfmt_elf.c
> > +++ b/fs/binfmt_elf.c
> > @@ -1652,6 +1652,7 @@ static int fill_files_note(struct memelfnote *note)
> >  	name_base = name_curpos = ((char *)data) + names_ofs;
> >  	remaining = size - names_ofs;
> >  	count = 0;
> > +	mmap_read_lock(mm);
> >  	for_each_vma(vmi, vma) {
> >  		struct file *file;
> >  		const char *filename;
> > @@ -1662,6 +1663,7 @@ static int fill_files_note(struct memelfnote *note)
> >  		filename = file_path(file, name_curpos, remaining);
> >  		if (IS_ERR(filename)) {
> >  			if (PTR_ERR(filename) == -ENAMETOOLONG) {
> > +				mmap_read_unlock(mm);
> >  				kvfree(data);
> >  				size = size * 5 / 4;
> >  				goto alloc;
> > @@ -1681,6 +1683,7 @@ static int fill_files_note(struct memelfnote *note)
> >  		*start_end_ofs++ = vma->vm_pgoff;
> >  		count++;
> >  	}
> > +	mmap_read_unlock(mm);
> >  
> >  	/* Now we know exact count of files, can store it */
> >  	data[0] = count;
>