| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <30ed8220-e24d-4b40-c7a6-4b09c84f9a1f@gmail.com>
Date: Mon, 31 Jan 2022 10:40:38 -0800
From: Florian Fainelli <f.fainelli@...il.com>
To: Saeed Mahameed <saeedm@...dia.com>,
Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: Stephen Hemminger <stephen@...workplumber.org>,
Saeed Mahameed <saeed@...nel.org>,
"David S. Miller" <davem@...emloft.net>,
Jakub Kicinski <kuba@...nel.org>,
Mark Einon <mark.einon@...il.com>,
Lino Sanfilippo <LinoSanfilippo@....de>,
Maxime Ripard <mripard@...nel.org>,
Chen-Yu Tsai <wens@...e.org>,
Jernej Skrabec <jernej.skrabec@...il.com>,
Shay Agroskin <shayagr@...zon.com>,
Arthur Kiyanovski <akiyano@...zon.com>,
David Arinzon <darinzon@...zon.com>,
Noam Dagan <ndagan@...zon.com>,
Saeed Bishara <saeedb@...zon.com>,
Chris Snook <chris.snook@...il.com>,
Nicolas Ferre <nicolas.ferre@...rochip.com>,
Claudiu Beznea <claudiu.beznea@...rochip.com>,
Hans Ulli Kroll <ulli.kroll@...glemail.com>,
Linus Walleij <linus.walleij@...aro.org>,
Jeroen de Borst <jeroendb@...gle.com>,
Catherine Sullivan <csully@...gle.com>,
David Awogbemila <awogbemila@...gle.com>,
Yisen Zhuang <yisen.zhuang@...wei.com>,
Salil Mehta <salil.mehta@...wei.com>,
Jesse Brandeburg <jesse.brandeburg@...el.com>,
Tony Nguyen <anthony.l.nguyen@...el.com>,
"K . Y . Srinivasan" <kys@...rosoft.com>,
Haiyang Zhang <haiyangz@...rosoft.com>,
Stephen Hemminger <sthemmin@...rosoft.com>,
Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
Vladimir Oltean <vladimir.oltean@....com>,
Claudiu Manoil <claudiu.manoil@....com>,
Alexandre Belloni <alexandre.belloni@...tlin.com>,
Microchip Linux Driver Support <UNGLinuxDriver@...rochip.com>,
Jon Mason <jdmason@...zu.us>,
Simon Horman <simon.horman@...igine.com>,
Rain River <rain.1986.08.12@...il.com>,
Zhu Yanjun <zyjzyj2000@...il.com>,
Shannon Nelson <snelson@...sando.io>, drivers@...sando.io,
Sergey Shtylyov <s.shtylyov@....ru>,
Jiri Pirko <jiri@...nulli.us>,
Edward Cree <ecree.xilinx@...il.com>,
Martin Habets <habetsm.xilinx@...il.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <Jose.Abreu@...opsys.com>,
Andy Gospodarek <andy@...yhouse.net>,
Michal Simek <michal.simek@...inx.com>,
Arnd Bergmann <arnd@...db.de>,
Jacob Keller <jacob.e.keller@...el.com>,
Vegard Nossum <vegard.nossum@...cle.com>,
Rob Herring <robh@...nel.org>, l.stelmach@...sung.com,
rafal@...ecki.pl, Edwin Peer <edwin.peer@...adcom.com>,
Geert Uytterhoeven <geert+renesas@...der.be>,
Michael Chan <michael.chan@...adcom.com>,
Richard Cochran <richardcochran@...il.com>,
Gerhard Engleder <gerhard@...leder-embedded.com>,
Marcin Wojtas <mw@...ihalf.com>,
Oleksij Rempel <linux@...pel-privat.de>,
Gabriel Somlo <gsomlo@...il.com>,
Joel Stanley <joel@....id.au>, Slark Xiao <slark_xiao@....com>,
Christophe Leroy <christophe.leroy@...roup.eu>,
Liming Sun <limings@...dia.com>,
David Thompson <davthompson@...dia.com>,
Asmaa Mnebhi <asmaa@...dia.com>,
Lars Povlsen <lars.povlsen@...rochip.com>,
Horatiu Vultur <horatiu.vultur@...rochip.com>,
Steen Hegelund <steen.hegelund@...rochip.com>,
Prabhakar Kushwaha <pkushwaha@...vell.com>,
Omkar Kulkarni <okulkarni@...vell.com>,
Shai Malin <smalin@...vell.com>,
Randy Dunlap <rdunlap@...radead.org>,
Vignesh Raghavendra <vigneshr@...com>,
Stefan Wahren <stefan.wahren@...e.com>,
Gary Guo <gary@...yguo.net>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-sunxi@...ts.linux.dev, intel-wired-lan@...ts.osuosl.org,
linux-hyperv@...r.kernel.org, oss-drivers@...igine.com,
linux-renesas-soc@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH net-next] net: kbuild: Don't default net vendor configs to
y
On 1/31/2022 10:35 AM, Saeed Mahameed wrote:
> On 31 Jan 19:30, Geert Uytterhoeven wrote:
>> On Mon, Jan 31, 2022 at 6:59 PM Stephen Hemminger
>> <stephen@...workplumber.org> wrote:
>>> On Mon, 31 Jan 2022 09:24:50 -0800
>>> Saeed Mahameed <saeed@...nel.org> wrote:
>>>
>>> > From: Saeed Mahameed <saeedm@...dia.com>
>>> >
>>> > NET_VENDOR_XYZ were defaulted to 'y' for no technical reason.
>>> >
>>> > Since all drivers belonging to a vendor are supposed to default to
>>> 'n',
>>> > defaulting all vendors to 'n' shouldn't be an issue, and aligns well
>>> > with the 'no new drivers' by default mentality.
>>> >
>>> > Signed-off-by: Saeed Mahameed <saeedm@...dia.com>
>>>
>>> This was done back when vendors were introduced in the network
>>> drivers tree.
>>> The default of Y allowed older configurations to just work.
>>
>> And changing the defaults means all defconfigs must be updated first,
>> else the user's configs will end up without drivers needed.
>>
>
> As I understand correctly, at least for most common net drivers, having
> NET_VENDOR_XYZ=y doesn't actually build anything, we have flags per
> module for each vendor and those are defaulted to N.
Right, but once you start hiding NET_VENDOR_DRIVER_XYZ under a
NET_VENDOR_XYZ Kconfig symbol dependency, if NET_VENDOR_XYZ is not set
to Y, then you have no way to select NET_VENDOR_DRIVER_XYZ and so your
old defconfig breaks.
>
>>> So there was a reason, not sure if it matters anymore.
>>> But it seems like useless repainting to change it now.
>>
>> It might make sense to tune some of the defaults (i.e. change to
>> "default y if ARCH_*") for drivers with clear platform dependencies.
>>
>
> either set hard default to 'n' or just keep it as is, anything else is just
> more confusion.
Maybe the rule should go like this: any new driver vendor defaults to n,
and existing ones remain set to y, until we deprecate doing that and
switching them all off to n by 5.18?
--
Florian
Powered by blists - more mailing lists