| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CAP-5=fWRq4WEYcZCskP+DRy0p1XOH+5mp_2L9YPi8+wjWeJsKA@mail.gmail.com>
Date: Mon, 31 Jan 2022 10:59:19 -0800
From: Ian Rogers <irogers@...gle.com>
To: "Liang, Kan" <kan.liang@...ux.intel.com>
Cc: Zhengjun Xing <zhengjun.xing@...ux.intel.com>,
Peter Zijlstra <peterz@...radead.org>,
Ingo Molnar <mingo@...hat.com>,
Arnaldo Carvalho de Melo <acme@...nel.org>,
Mark Rutland <mark.rutland@....com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
Jiri Olsa <jolsa@...hat.com>,
Namhyung Kim <namhyung@...nel.org>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Andi Kleen <ak@...ux.intel.com>,
James Clark <james.clark@....com>,
John Garry <john.garry@...wei.com>,
linux-kernel@...r.kernel.org, linux-perf-users@...r.kernel.org,
Stephane Eranian <eranian@...gle.com>
Subject: Re: [PATCH 03/26] perf vendor events: Update metrics for Broadwell DE
On Mon, Jan 31, 2022 at 5:54 AM Liang, Kan <kan.liang@...ux.intel.com> wrote:
>
>
>
> On 1/29/2022 3:09 AM, Ian Rogers wrote:
> > Based on TMA_metrics-full.csv version 4.3 at 01.org:
> > https://download.01.org/perfmon/
> > Events are still at version 7:
> > https://download.01.org/perfmon/BDW-DE
> > Json files generated by:
> > https://github.com/intel/event-converter-for-linux-perf
> >
> > This adds TopdownL1_SMT metrics to bdwde-metrics.json as
> > generated by the extract-tmam.py script.
> >
> > Tested:
> > ...
> > 6: Parse event definition strings : Ok
> > 7: Simple expression parser : Ok
> > ...
> > 9: Parse perf pmu format : Ok
> > 10: PMU events :
> > 10.1: PMU event table sanity : Ok
> > 10.2: PMU event map aliases : Ok
> > 10.3: Parsing of PMU event table metrics : Skip (some metrics failed)
> > 10.4: Parsing of PMU event table metrics with fake PMUs : Ok
> > ...
> > 68: Parse and process metrics : Ok
> > ...
> > 88: perf stat metrics (shadow stat) test : Ok
> > 89: perf all metricgroups test : FAILED!
> > 90: perf all metrics test : FAILED!
> > 91: perf all PMU test : Ok
> > ...
> > The failures/skips relate to:
> > event syntax error: '{arb/event=0x84,umask=0x1,metric-id=arb!3event!20x84!0umask!20x1!3/,arb/even..'
> > \___ Cannot find PMU `arb'. Missing kernel support?
> >
>
> ARB is an uncore unit for client platforms. Broadwell DE should be a
> server platform. It looks like an issue of TMA_metrics-full.csv.
> I will check and see whether we can fix the TMA file.
I modified the TMA_Metrics-full.csv to change the BDX column to be
BDX/BDW-DE and the BDW/BDW-DE column to be BDW. Doing this and then
applying a corresponding change to extract-tma-metrics.py (below)
created a perf json metric file that passed all the tests. I will
resend the generated files in a v2.
Thanks,
Ian
```
diff --git a/extract-tma-metrics.py b/extract-tma-metrics.py
index ed22e05..5c872ba 100755
--- a/extract-tma-metrics.py
+++ b/extract-tma-metrics.py
@@ -93,16 +93,16 @@ ratio_column = {
"IVB": ("IVB", "SNB", ),
"HSW": ("HSW", "IVB", "SNB", ),
"HSX": ("HSX", "HSW", "IVT", "IVB", "JKT/SNB-EP", "SNB"),
- "BDW/BDW-DE": ("BDW/BDW-DE", "HSW", "IVB", "SNB", ),
- "BDX": ("BDX", "BDW/BDW-DE", "HSX", "HSW", "IVT", "IVB",
"JKT/SNB-EP", "SNB"),
+ "BDW": ("BDW", "HSW", "IVB", "SNB", ),
+ "BDX/BDW-DE": ("BDX/BDW-DE", "BDW", "HSX", "HSW", "IVT", "IVB",
"JKT/SNB-EP", "SNB"),
"SNB": ("SNB", ),
"JKT/SNB-EP": ("JKT/SNB-EP", "SNB"),
- "SKL/KBL": ("SKL/KBL", "BDW/BDW-DE", "HSW", "IVB", "SNB"),
- "SKX": ("SKX", "SKL/KBL", "BDX", "BDW/BDW-DE", "HSX", "HSW",
"IVT", "IVB", "JKT/SNB-EP", "SNB"),
- "KBLR/CFL": ("KBLR/CFL", "SKL/KBL", "BDW/BDW-DE", "HSW", "IVB", "SNB"),
- "CLX": ("CLX", "KBLR/CFL/CML", "SKX", "SKL/KBL", "BDX",
"BDW/BDW-DE", "HSX", "HSW", "IVT", "IVB", "JKT/SNB-EP", "SNB"),
- "ICL": ("ICL", "CNL", "KBLR/CFL/CML", "SKL/KBL", "BDW/BDW-DE",
"HSW", "IVB", "SNB"),
- "ICX": ("ICX", "ICL", "CNL", "CPX", "CLX", "KBLR/CFL/CML", "SKX",
"SKL/KBL", "BDX", "BDW/BDW-DE", "HSX", "HSW", "IVT", "IVB",
"JKT/SNB-EP", "SNB"),
+ "SKL/KBL": ("SKL/KBL", "BDW", "HSW", "IVB", "SNB"),
+ "SKX": ("SKX", "SKL/KBL", "BDX/BDW-DE", "BDW", "HSX", "HSW",
"IVT", "IVB", "JKT/SNB-EP", "SNB"),
+ "KBLR/CFL": ("KBLR/CFL", "SKL/KBL", "BDW", "HSW", "IVB", "SNB"),
+ "CLX": ("CLX", "KBLR/CFL/CML", "SKX", "SKL/KBL", "BDX/BDW-DE",
"BDW", "HSX", "HSW", "IVT", "IVB", "JKT/SNB-EP", "SNB"),
+ "ICL": ("ICL", "CNL", "KBLR/CFL/CML", "SKL/KBL", "BDW", "HSW",
"IVB", "SNB"),
+ "ICX": ("ICX", "ICL", "CNL", "CPX", "CLX", "KBLR/CFL/CML", "SKX",
"SKL/KBL", "BDX/BDW-DE", "BDW", "HSX", "HSW", "IVT", "IVB",
"JKT/SNB-EP", "SNB"),
}
ap = argparse.ArgumentParser()
```
> Thanks,
> Kan
>
> > Signed-off-by: Ian Rogers<irogers@...gle.com>
> > ---
> > .../arch/x86/broadwellde/bdwde-metrics.json | 401 +++-
> > .../arch/x86/broadwellde/cache.json | 1122 +++++-----
> > .../arch/x86/broadwellde/floating-point.json | 222 +-
> > .../arch/x86/broadwellde/frontend.json | 335 +--
> > .../arch/x86/broadwellde/memory.json | 608 +++---
> > .../arch/x86/broadwellde/other.json | 28 +-
> > .../arch/x86/broadwellde/pipeline.json | 1892 ++++++++---------
> > .../arch/x86/broadwellde/virtual-memory.json | 394 ++--
> > 8 files changed, 2646 insertions(+), 2356 deletions(-)
Powered by blists - more mailing lists