linux-kernel - Re: [PATCH] acpi: require CRC32 to build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6502adba-c91b-cafa-35a5-635636b31075@intel.com>
Date:   Mon, 31 Jan 2022 20:17:33 +0100
From:   "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>
To:     Guenter Roeck <linux@...ck-us.net>,
        Randy Dunlap <rdunlap@...radead.org>,
        <linux-kernel@...r.kernel.org>, <linux-next@...r.kernel.org>
CC:     Heikki Krogerus <heikki.krogerus@...ux.intel.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [PATCH] acpi: require CRC32 to build

On 1/30/2022 11:58 PM, Guenter Roeck wrote:
> On 1/30/22 14:38, Randy Dunlap wrote:
>> ACPI core now requires crc32() but the kernel build can fail when
>> CRC32 is not set/enabled, so select it in the ACPI Kconfig entry.
>>
>> Fixes this build error:
>>
>> ia64-linux-ld: drivers/acpi/scan.o: in function `acpi_store_pld_crc':
>> include/acpi/platform/aclinuxex.h:62: undefined reference to `crc32_le'
>>
>> Fixes: 882c982dada4 ("acpi: Store CRC-32 hash of the _PLD in struct 
>> acpi_device")
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> Reported-by: Guenter Roeck <linux@...ck-us.net>
>> Cc: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
>> Cc: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
>> Cc: Linus Torvalds <torvalds@...ux-foundation.org>
>
> Reviewed-by: Guenter Roeck <linux@...ck-us.net>
> Tested-by: Guenter Roeck <linux@...ck-us.net>
>
Applied as 5.17-rc material, thanks!


>> ---
>>   drivers/acpi/Kconfig |    1 +
>>   1 file changed, 1 insertion(+)
>>
>> --- linux-next-20220128.orig/drivers/acpi/Kconfig
>> +++ linux-next-20220128/drivers/acpi/Kconfig
>> @@ -11,6 +11,7 @@ menuconfig ACPI
>>       depends on ARCH_SUPPORTS_ACPI
>>       select PNP
>>       select NLS
>> +    select CRC32
>>       default y if X86
>>       help
>>         Advanced Configuration and Power Interface (ACPI) support for
>