linux-kernel - Re: [PATCH] staging: pi433: remove unnecessary new line escape sequence characters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Yfg42KS3sQ8PZmo1@mail.google.com>
Date:   Tue, 1 Feb 2022 08:30:32 +1300
From:   Paulo Miguel Almeida <paulo.miguel.almeida.rodenas@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
Cc:     gregkh@...uxfoundation.org, realwakka@...il.com,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: pi433: remove unnecessary new line escape
 sequence characters

On Mon, Jan 31, 2022 at 01:40:20PM +0300, Dan Carpenter wrote:
> >  	if (device->irq_state[DIO0] == DIO_PACKET_SENT) {
> >  		device->free_in_fifo = FIFO_SIZE;
> > -		dev_dbg(device->dev, "DIO0 irq: Packet sent\n");
> > +		dev_dbg(device->dev, "DIO0 irq: Packet sent");
> 
> Both the old and new code will do the same thing.  You are correct.
> However in terms of style, I believe the preference is to add a newline.
> 
> I don't remember the reasoning behind this.  But a lot of these style
> rules are just decided by consensus.  If you do a
> `git grep -w dev_dbg | grep \;$` then it is 12391 places that add a
> new line and 622 which don't.  Adding a newline is the clear winner.
> 

it makes sense. I will send a different patch adding the newline escapes
instead. 

Thanks heaps! 

Paulo Almeida