linux-kernel - Re: [PATCH V8 18/44] x86/fault: Add a PKS test fault hook

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2a7b0a94ea52952927c29bfc32f0085cbdfe5747.camel@intel.com>
Date:   Mon, 31 Jan 2022 19:56:57 +0000
From:   "Edgecombe, Rick P" <rick.p.edgecombe@...el.com>
To:     "hpa@...or.com" <hpa@...or.com>,
        "Williams, Dan J" <dan.j.williams@...el.com>,
        "Weiny, Ira" <ira.weiny@...el.com>,
        "dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>
CC:     "Yu, Fenghua" <fenghua.yu@...el.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH V8 18/44] x86/fault: Add a PKS test fault hook

On Thu, 2022-01-27 at 09:54 -0800, ira.weiny@...el.com wrote:
> +                * If a protection key exception occurs it could be
> because a PKS test
> +                * is running.  If so, pks_test_callback() will clear
> the protection
> +                * mechanism and return true to indicate the fault
> was handled.
> +                */
> +               if (pks_test_callback())
> +                       return;

Why do we need both this and pks_handle_key_fault()?