linux-kernel - Re: [PATCH] rtlwifi: remove redundant initialization of variable ul

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 31 Jan 2022 02:53:40 +0000
From:   Pkshih <pkshih@...ltek.com>
To:     "kvalo@...nel.org" <kvalo@...nel.org>,
        "linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
        "colin.i.king@...il.com" <colin.i.king@...il.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rtlwifi: remove redundant initialization of variable ul_encalgo

On Sun, 2022-01-30 at 22:37 +0000, Colin Ian King wrote:
> Variable ul_encalgo is initialized with a value that is never read,
> it is being re-assigned a new value in every case in the following
> switch statement. The initialization is redundant and can be removed.
> 
> Signed-off-by: Colin Ian King <colin.i.king@...il.com>

Acked-by: Ping-Ke Shih <pkshih@...ltek.com>

> ---
>  drivers/net/wireless/realtek/rtlwifi/cam.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/wireless/realtek/rtlwifi/cam.c
> b/drivers/net/wireless/realtek/rtlwifi/cam.c
> index 7a0355dc6bab..32970ea4b4e7 100644
> --- a/drivers/net/wireless/realtek/rtlwifi/cam.c
> +++ b/drivers/net/wireless/realtek/rtlwifi/cam.c
> @@ -208,7 +208,7 @@ void rtl_cam_empty_entry(struct ieee80211_hw *hw, u8 uc_index)
>  
>  	u32 ul_command;
>  	u32 ul_content;
> -	u32 ul_encalgo = rtlpriv->cfg->maps[SEC_CAM_AES];
> +	u32 ul_encalgo;
>  	u8 entry_i;
>  
>  	switch (rtlpriv->sec.pairwise_enc_algorithm) {
> -- 

When I check this patch, I find there is no 'break' for default case.
Do we need one? like

@@ -226,6 +226,7 @@ void rtl_cam_empty_entry(struct ieee80211_hw *hw, u8 uc_index)
                break;
        default:
                ul_encalgo = rtlpriv->cfg->maps[SEC_CAM_AES];
+               break;
        }
 
        for (entry_i = 0; entry_i < CAM_CONTENT_COUNT; entry_i++) {

--
Ping-Ke