linux-kernel - Re: [PATCH 3/3] iio: accel: st_accel: Add support for Silan SC7A20

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdb407XmMGSM+7okOx50ZNTK3UuHWSFSH+CZ_2bQS0NJ=w@mail.gmail.com>
Date:   Mon, 31 Jan 2022 12:23:22 +0100
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Jonathan Cameron <jic23@...nel.org>
Cc:     Samuel Holland <samuel@...lland.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Denis Ciocca <denis.ciocca@...com>,
        Rob Herring <robh+dt@...nel.org>, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org
Subject: Re: [PATCH 3/3] iio: accel: st_accel: Add support for Silan SC7A20

On Sun, Jan 30, 2022 at 3:04 PM Jonathan Cameron <jic23@...nel.org> wrote:

> This is nasty as 0x11 is a valid who am I for an LIS3DHH which is a very
> different device.

The WAI value is just a second line check anyway, the device is probed
from the compatible, this is just checked to make sure the device is
what it says it is. Annoying, but it will do the job.

> It's worth noting that a good part of the maintenance of this driver is
> done by ST employees who are probably less than happy with seeing
> a clone (with bugs) supported.  So support is likely to be somewhat best
> effort / not going to deliberately break support for this part but no
> means to test it. Hopefully we'll remember to cc you to test anything new added to
> the driver.  Clones aren't always perfect!

Linux began with people running it on IBM PC clones... ;)

I would assume good faith, especially with the silicon shortage
plaguing us it is
perfectly possible that this is a fully licensed copy. I think the two
derivatives of the AK8974 magnetometer for example are
legally transferred IP, we just don't know the details behind the curtain.

Yours,
Linus Walleij