linux-kernel - Re: [PATCH] ARM: dts: wpcm450: Enable watchdog by default

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACPK8XfMm7jJ9QYOBr1HiR_22xPEzx9MZXO_CX7MpQt2QAVSUg@mail.gmail.com>
Date:   Mon, 31 Jan 2022 06:37:51 +0000
From:   Joel Stanley <joel@....id.au>
To:     Jonathan Neuschäfer <j.neuschaefer@....net>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        devicetree <devicetree@...r.kernel.org>,
        OpenBMC Maillist <openbmc@...ts.ozlabs.org>,
        Rob Herring <robh+dt@...nel.org>
Subject: Re: [PATCH] ARM: dts: wpcm450: Enable watchdog by default

On Fri, 28 Jan 2022 at 22:11, Jonathan Neuschäfer <j.neuschaefer@....net> wrote:
>
> The watchdog timer is always usable, regardless of board design, so
> there is no point in marking the watchdog device as disabled-by-default
> in nuvoton-wpcm450.dtsi.
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@....net>

I assume this makes it always available for rebooting the system too?

Reviewed-by: Joel Stanley <joel@....id.au>

> ---
>  arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts | 4 ----
>  arch/arm/boot/dts/nuvoton-wpcm450.dtsi                      | 1 -
>  2 files changed, 5 deletions(-)
>
> diff --git a/arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts b/arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts
> index 3ee61251a16d0..1ae7ae4804275 100644
> --- a/arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts
> +++ b/arch/arm/boot/dts/nuvoton-wpcm450-supermicro-x9sci-ln4f.dts
> @@ -77,7 +77,3 @@ &serial1 {
>         /* "Serial over LAN" port. Connected to ttyS2 of the host system. */
>         status = "okay";
>  };
> -
> -&watchdog0 {
> -       status = "okay";
> -};
> diff --git a/arch/arm/boot/dts/nuvoton-wpcm450.dtsi b/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
> index 93595850a4c3c..b9b669cd632f1 100644
> --- a/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
> +++ b/arch/arm/boot/dts/nuvoton-wpcm450.dtsi
> @@ -81,7 +81,6 @@ watchdog0: watchdog@...0101c {
>                         interrupts = <1 IRQ_TYPE_LEVEL_HIGH>;
>                         reg = <0xb800101c 0x4>;
>                         clocks = <&clk24m>;
> -                       status = "disabled";
>                 };
>
>                 aic: interrupt-controller@...02000 {
> --
> 2.34.1
>