linux-kernel - Re: [PATCH V4 03/17] asm-generic: compat: Cleanup duplicate definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Mon, 31 Jan 2022 04:21:26 -0800
From:   Christoph Hellwig <hch@...radead.org>
To:     guoren@...nel.org
Cc:     palmer@...belt.com, arnd@...db.de, anup@...infault.org,
        gregkh@...uxfoundation.org, liush@...winnertech.com,
        wefu@...hat.com, drew@...gleboard.org, wangjunqiang@...as.ac.cn,
        linux-arch@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-riscv@...ts.infradead.org, linux-csky@...r.kernel.org,
        linux-s390@...r.kernel.org, sparclinux@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, linux-parisc@...r.kernel.org,
        linux-mips@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        x86@...nel.org, Guo Ren <guoren@...ux.alibaba.com>
Subject: Re: [PATCH V4 03/17] asm-generic: compat: Cleanup duplicate
 definitions

On Sat, Jan 29, 2022 at 08:17:14PM +0800, guoren@...nel.org wrote:
> From: Guo Ren <guoren@...ux.alibaba.com>
> 
> There are 7 64bit architectures that support Linux COMPAT mode to
> run 32bit applications. A lot of definitions are duplicate:
>  - COMPAT_USER_HZ
>  - COMPAT_RLIM_INFINITY
>  - COMPAT_OFF_T_MAX
>  - __compat_uid_t, __compat_uid_t
>  - compat_dev_t
>  - compat_ipc_pid_t
>  - struct compat_flock
>  - struct compat_flock64
>  - struct compat_statfs
>  - struct compat_ipc64_perm, compat_semid64_ds,
> 	  compat_msqid64_ds, compat_shmid64_ds
> 
> Cleanup duplicate definitions and merge them into asm-generic.

The flock part seems to clash with the general compat_flock
consolidation.  Otherwise this looks like a good idea.