linux-kernel - Re: [PATCH v4 00/23] staging: r8188eu: remove unneeded ret variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YffeDdW5gPDIXR9f@kroah.com>
Date:   Mon, 31 Jan 2022 14:03:09 +0100
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Abdun Nihaal <abdun.nihaal@...il.com>
Cc:     Larry.Finger@...inger.net, phil@...lpotter.co.uk,
        straube.linux@...il.com, martin@...ser.cx,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v4 00/23] staging: r8188eu: remove unneeded ret variables

On Sat, Jan 29, 2022 at 09:34:06PM +0530, Abdun Nihaal wrote:
> This patchset does the following to functions in ioctl_linux.c:
> - Remove unneeded return variable in some functions.
>   These functions cannot be converted to void either because it is an
>   iw_handler function or the function does return error code.
> - Propagate error code in rtw_p2p_get2 function
> - Convert some functions that always return 0 to return void
> 
> v3 -> v4:
> - Split the changes into smaller patches to make it easier to review
> - Add a new patch to propagate error code in rtw_p2p_get2 function

Much nicer and easier to review, all now queued up, thanks!

greg k-h