linux-kernel - Re: [PATCH 3/6] mm, memory_hotplug: drop arch_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220201024152.uqksmmethxs4q2pe@master>
Date:   Tue, 1 Feb 2022 02:41:52 +0000
From:   Wei Yang <richard.weiyang@...il.com>
To:     Michal Hocko <mhocko@...nel.org>
Cc:     Andrew Morton <akpm@...ux-foundation.org>, linux-mm@...ck.org,
        LKML <linux-kernel@...r.kernel.org>,
        David Hildenbrand <david@...hat.com>,
        Alexey Makhalov <amakhalov@...are.com>,
        Dennis Zhou <dennis@...nel.org>,
        Eric Dumazet <eric.dumazet@...il.com>,
        Oscar Salvador <osalvador@...e.de>, Tejun Heo <tj@...nel.org>,
        Christoph Lameter <cl@...ux.com>,
        Nico Pache <npache@...hat.com>,
        Wei Yang <richard.weiyang@...il.com>,
        Rafael Aquini <raquini@...hat.com>,
        Michal Hocko <mhocko@...e.com>
Subject: Re: [PATCH 3/6] mm, memory_hotplug: drop arch_free_nodedata

On Thu, Jan 27, 2022 at 09:53:02AM +0100, Michal Hocko wrote:
>From: Michal Hocko <mhocko@...e.com>
>
>Prior to "mm: handle uninitialized numa nodes gracefully" memory hotplug
>used to allocate pgdat when memory has been added to a node
>(hotadd_init_pgdat) arch_free_nodedata has been only used in the
>failure path because once the pgdat is exported (to be visible
>by NODA_DATA(nid)) it cannot really be freed because there is no
>synchronization available for that.
>
>pgdat is allocated for each possible nodes now so the memory hotplug
>doesn't need to do the ever use arch_free_nodedata so drop it.
>
>This patch doesn't introduce any functional change.
>
>Acked-by: Rafael Aquini <raquini@...hat.com>
>Signed-off-by: Michal Hocko <mhocko@...e.com>

Reviewed-by: Wei Yang <richard.weiyang@...il.com>
-- 
Wei Yang
Help you, Help me