linux-kernel - Re: [PATCH 4/5] arm64: dts: qcom: sc7280: Clean up sdc1 / sdc2 pinctrl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAD=FV=XhVC2g+Me_7Hj=cKEz_GxUJao7OSbfV-nT6GS535SpOA@mail.gmail.com>
Date:   Mon, 31 Jan 2022 16:34:41 -0800
From:   Doug Anderson <dianders@...omium.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>
Cc:     Shaik Sajida Bhanu <sbhanu@...eaurora.org>,
        Matthias Kaehlcke <mka@...omium.org>,
        Stephen Boyd <swboyd@...omium.org>,
        Andy Gross <agross@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
        <devicetree@...r.kernel.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 4/5] arm64: dts: qcom: sc7280: Clean up sdc1 / sdc2 pinctrl

Hi,

On Mon, Jan 31, 2022 at 4:33 PM Bjorn Andersson
<bjorn.andersson@...aro.org> wrote:
>
> On Mon 31 Jan 18:25 CST 2022, Doug Anderson wrote:
>
> > Hi,
> >
> > On Mon, Jan 31, 2022 at 4:11 PM Douglas Anderson <dianders@...omium.org> wrote:
> > >
> > > diff --git a/arch/arm64/boot/dts/qcom/sc7280.dtsi b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > > index 40cb414bc377..dc98a87e2871 100644
> > > --- a/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > > +++ b/arch/arm64/boot/dts/qcom/sc7280.dtsi
> > > @@ -616,6 +616,9 @@ qfprom: efuse@...000 {
> > >
> > >                 sdhc_1: sdhci@...000 {
> > >                         compatible = "qcom,sc7280-sdhci", "qcom,sdhci-msm-v5";
> > > +                       pinctrl-names = "default", "sleep";
> > > +                       pinctrl-0 = <&sdc1_clk>, <&sdc1_cmd>, <&sdc1_data>, <&sdc1_rclk>;
> > > +                       pinctrl-1 = <&sdc1_clk_sleep>, <&sdc1_cmd_sleep>, <&sdc1_data_sleep>, <&sdc1_rclk_sleep>;
> > >                         status = "disabled";
> > >
> > >                         reg = <0 0x007c4000 0 0x1000>,
> > > @@ -2425,6 +2428,9 @@ apss_merge_funnel_in: endpoint {
> > >
> > >                 sdhc_2: sdhci@...4000 {
> > >                         compatible = "qcom,sc7280-sdhci", "qcom,sdhci-msm-v5";
> > > +                       pinctrl-names = "default", "sleep";
> > > +                       pinctrl-0 = <&sdc2_clk>, <&sdc2_cmd>, <&sdc2_data>;
> > > +                       pinctrl-1 = <&sdc2_clk_sleep>, <&sdc2_cmd_sleep>, <&sdc2_data_sleep>;
> > >                         status = "disabled";
> > >
> > >                         reg = <0 0x08804000 0 0x1000>;
> > > @@ -3943,81 +3949,76 @@ qup_uart15_rx: qup-uart15-rx {
> > >                                 function = "qup17";
> > >                         };
> > >
> > > -                       sdc1_on: sdc1-on {
> > > -                               clk {
> > > -                                       pins = "sdc1_clk";
> > > -                               };
> > >
> > > -                               cmd {
> > > -                                       pins = "sdc1_cmd";
> > > -                               };
> > >
> > > -                               data {
> > > -                                       pins = "sdc1_data";
> > > -                               };
> > > +                       sdc1_clk: sdc1-clk {
> >
> > Ugh. I just noticed that there are way too many blank lines here in
> > the output. Happy to have this fixed when applying or I can post a v2.
> >
>
> I can fix that up as I apply it. Will let it sit for a few days to
> attract reviews first though.

Sounds good. Thanks! I might end up sending a v2 anyway since I found
a few more fixups, but I'll at least wait a day or two so I don't spam
people too hard.

-Doug