lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 1 Feb 2022 09:08:59 +0000 From: Tvrtko Ursulin <tvrtko.ursulin@...ux.intel.com> To: Stephen Rothwell <sfr@...b.auug.org.au>, Daniel Vetter <daniel.vetter@...ll.ch>, Jani Nikula <jani.nikula@...ux.intel.com>, Joonas Lahtinen <joonas.lahtinen@...ux.intel.com>, Rodrigo Vivi <rodrigo.vivi@...el.com>, Intel Graphics <intel-gfx@...ts.freedesktop.org>, DRI <dri-devel@...ts.freedesktop.org> Cc: Linux Next Mailing List <linux-next@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org>, Dan Carpenter <dan.carpenter@...cle.com> Subject: Re: [Intel-gfx] linux-next: build failure after merge of the drm-intel-fixes tree On 31/01/2022 22:27, Stephen Rothwell wrote: > Hi all, > > After merging the drm-intel-fixes tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/gpu/drm/i915/i915_vma.c: In function 'i915_vma_bind': > drivers/gpu/drm/i915/i915_vma.c:451:25: error: 'ret' undeclared (first use in this function); did you mean 'net'? > 451 | ret = i915_gem_object_wait_moving_fence(vma->obj, true); > | ^~~ > | net > > Caused by commit > > 2e872d87cbf2 ("drm/i915: delete shadow "ret" variable") > > I have reverted that commit for today. Dropping was the right call - I have since removed it from drm-intel-fixes as well. Root cause was a bad Fixes: tag in that patch which caused it to be wrongly cherry-picked and I did not build test before pushing. We can't edit the wrong Fixes: tag now, so for future reference only, 2e872d87cbf2 ("drm/i915: delete shadow "ret" variable") should not be backported to 5.17 by anyone. Wrong tag: Fixes: f6c466b84cfa ("drm/i915: Add support for moving fence waiting") Correct tag should have been: Fixes: 2f6b90da9192 ("drm/i915: Use vma resources for async unbinding") Regards, Tvrtko
Powered by blists - more mailing lists