linux-kernel - Re: [PATCH v5 08/13] ACPI: add perf low power callback

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220201102029.GS20638@worktop.programming.kicks-ass.net>
Date:   Tue, 1 Feb 2022 11:20:29 +0100
From:   Peter Zijlstra <peterz@...radead.org>
To:     Stephane Eranian <eranian@...gle.com>
Cc:     linux-kernel@...r.kernel.org, kim.phillips@....com,
        acme@...hat.com, jolsa@...hat.com, songliubraving@...com,
        "Rafael J. Wysocki" <rjw@...ysocki.net>, linux-acpi@...r.kernel.org
Subject: Re: [PATCH v5 08/13] ACPI: add perf low power callback

On Mon, Jan 31, 2022 at 11:33:10PM -0800, Stephane Eranian wrote:
> On Thu, Jan 27, 2022 at 5:06 AM Peter Zijlstra <peterz@...radead.org> wrote:
> >
> > On Wed, Jan 26, 2022 at 03:34:49PM -0800, Stephane Eranian wrote:
> > > This patch add an optional callback needed by some PMU features, e.g., AMD
> >
> > "This patch" is a documented fail.
> >
> I understand this is not ideal.

git grep -i "this patch" Documentation/process/submitting-patches.rst

"Describe your changes in imperative mood, e.g. "make xyzzy do frotz"
instead of "[This patch] makes xyzzy do frotz" or "[I] changed xyzzy
to do frotz", as if you are giving orders to the codebase to change
its behaviour."

IOW, don't use "This patch" to start a Changelog (lot's of your patches
here do so).