linux-kernel - Re: [PATCH] ipw2100: inproper error handling of ipw2100_pci_init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <164371770337.16633.7286807059175242667.kvalo@kernel.org>
Date:   Tue,  1 Feb 2022 12:15:04 +0000 (UTC)
From:   Kalle Valo <kvalo@...nel.org>
To:     Peiwei Hu <jlu.hpw@...mail.com>
Cc:     stas.yakovlev@...il.com, kvalo@...eaurora.org, davem@...emloft.net,
        kuba@...nel.org, linux-wireless@...r.kernel.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        trivial@...nel.org, Peiwei Hu <jlu.hpw@...mail.com>
Subject: Re: [PATCH] ipw2100: inproper error handling of ipw2100_pci_init_one

Peiwei Hu <jlu.hpw@...mail.com> wrote:

> goto fail instead of returning directly in error exiting
> 
> Signed-off-by: Peiwei Hu <jlu.hpw@...mail.com>

The commit log does not answer to "why?". Also looking at
ipw2100_pci_init_one() I think it would need more cleanup in error
handling, for example pci_ionumap() is called in different order etc.

Patch set to Changes Requested.

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/tencent_205AA371C910BBA2CF01B311811ABDF2560A@qq.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches