linux-kernel - Re: [PATCH] powerpc/xive: Add some error handling code to 'xive_spapr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c66aab06-f805-f591-0d08-31319885b912@csgroup.eu>
Date:   Tue, 1 Feb 2022 13:39:37 +0000
From:   Christophe Leroy <christophe.leroy@...roup.eu>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        "benh@...nel.crashing.org" <benh@...nel.crashing.org>,
        "paulus@...ba.org" <paulus@...ba.org>,
        "mpe@...erman.id.au" <mpe@...erman.id.au>,
        "allison@...utok.net" <allison@...utok.net>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "clg@...d.org" <clg@...d.org>, "groug@...d.org" <groug@...d.org>
CC:     "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] powerpc/xive: Add some error handling code to
 'xive_spapr_init()'



Le 01/02/2022 à 13:32, Christophe JAILLET a écrit :
> Le 01/02/2022 à 12:31, Christophe Leroy a écrit :
>> Hi,
>>
>> Le 01/08/2019 à 13:09, Christophe JAILLET a écrit :
>>> 'xive_irq_bitmap_add()' can return -ENOMEM.
>>> In this case, we should free the memory already allocated and return
>>> 'false' to the caller.
>>>
>>> Also add an error path which undoes the 'tima = ioremap(...)'
>>
>> This old patch doesn't apply, if it is still relevant can you please 
>> rebase ?
>>
>> Thanks
>> Christophe
>>
> 
> Hi, funny to see a 2 1/2 years old patch to pop-up like that :)
> It still looks relevant to me.

Yeah I'm trying to clean some dust in Patchwork.

> 
> V2 sent.
> Still not compile tested.
> 

At least it's all green at 
https://patchwork.ozlabs.org/project/linuxppc-dev/patch/564998101804886b151235c8a9f93020923bfd2c.1643718324.git.christophe.jaillet@wanadoo.fr/

Christophe