linux-kernel - Re: [PATCH 2/4] clk: loongson1: Terminate clk_div

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAAdtpL5xVjiKSFVcdFiMQHrki2bDSbDppP65QDC5ybBp3u-kMw@mail.gmail.com>
Date:   Tue, 1 Feb 2022 14:57:03 +0100
From:   Philippe Mathieu-Daudé <f4bug@...at.org>
To:     Jonathan Neuschäfer <j.neuschaefer@....net>
Cc:     linux-clk <linux-clk@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Keguang Zhang <keguang.zhang@...il.com>,
        Michael Turquette <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        "open list:BROADCOM NVRAM DRIVER" <linux-mips@...r.kernel.org>
Subject: Re: [PATCH 2/4] clk: loongson1: Terminate clk_div_table with sentinel element

On Mon, Jan 31, 2022 at 12:48 PM Jonathan Neuschäfer
<j.neuschaefer@....net> wrote:
>
> In order that the end of a clk_div_table can be detected, it must be
> terminated with a sentinel element (.div = 0).
>
> Signed-off-by: Jonathan Neuschäfer <j.neuschaefer@....net>
> ---
>  drivers/clk/loongson1/clk-loongson1c.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/loongson1/clk-loongson1c.c b/drivers/clk/loongson1/clk-loongson1c.c
> index 703f87622cf5f..6b29ae9ede3e5 100644
> --- a/drivers/clk/loongson1/clk-loongson1c.c
> +++ b/drivers/clk/loongson1/clk-loongson1c.c
> @@ -37,6 +37,7 @@ static const struct clk_div_table ahb_div_table[] = {
>         [1] = { .val = 1, .div = 4 },
>         [2] = { .val = 2, .div = 3 },
>         [3] = { .val = 3, .div = 3 },
> +       [4] = { .val = 0, .div = 0 },

Easier to review when self-explicit:

        [4] = { /* sentinel */ }

Preferably updated:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@...at.org>

And eventually:
Fixes: b4626a7f4892 ("CLK: Add Loongson1C clock support")

>  };
>
>  void __init ls1x_clk_init(void)
> --
> 2.34.1
>