linux-kernel - [dvyukov:dvyukov-sigtrap-arm64 1/1] arch/arm64/kernel/signal.c:566:39: error: 'sf' undeclared; did you mean 's8'?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Tue, 1 Feb 2022 22:17:38 +0800
From:   kernel test robot <lkp@...el.com>
To:     Dmitry Vyukov <dvyukov@...gle.com>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [dvyukov:dvyukov-sigtrap-arm64 1/1]
 arch/arm64/kernel/signal.c:566:39: error: 'sf' undeclared; did you mean
 's8'?

tree:   https://github.com/dvyukov/linux dvyukov-sigtrap-arm64
head:   dfd6903d9c6538e3ad792c1df6ffbcce2072b12b
commit: dfd6903d9c6538e3ad792c1df6ffbcce2072b12b [1/1] arm64: try to fix arm64 watchpoints
config: arm64-allyesconfig (https://download.01.org/0day-ci/archive/20220201/202202012216.ccEQmUmT-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/dvyukov/linux/commit/dfd6903d9c6538e3ad792c1df6ffbcce2072b12b
        git remote add dvyukov https://github.com/dvyukov/linux
        git fetch --no-tags dvyukov dvyukov-sigtrap-arm64
        git checkout dfd6903d9c6538e3ad792c1df6ffbcce2072b12b
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=arm64 SHELL=/bin/bash arch/arm64/kernel/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All error/warnings (new ones prefixed by >>):

   arch/arm64/kernel/signal.c: In function '__arm64_sys_rt_sigreturn':
>> arch/arm64/kernel/signal.c:566:39: error: 'sf' undeclared (first use in this function); did you mean 's8'?
     566 |         if (!__copy_from_user(&info, &sf->info, sizeof(info)) &&
         |                                       ^~
         |                                       s8
   arch/arm64/kernel/signal.c:566:39: note: each undeclared identifier is reported only once for each function it appears in
   arch/arm64/kernel/signal.c: At top level:
   arch/arm64/kernel/signal.c:930:6: warning: no previous prototype for 'do_notify_resume' [-Wmissing-prototypes]
     930 | void do_notify_resume(struct pt_regs *regs, unsigned long thread_flags)
         |      ^~~~~~~~~~~~~~~~
--
>> arch/arm64/kernel/hw_breakpoint.c:754:6: warning: no previous prototype for 'hw_bp_single_step' [-Wmissing-prototypes]
     754 | void hw_bp_single_step(struct pt_regs *regs)
         |      ^~~~~~~~~~~~~~~~~


vim +566 arch/arm64/kernel/signal.c

   536	
   537	SYSCALL_DEFINE0(rt_sigreturn)
   538	{
   539		struct pt_regs *regs = current_pt_regs();
   540		struct rt_sigframe __user *frame;
   541		struct siginfo info;
   542	
   543		/* Always make any pending restarted system calls return -EINTR */
   544		current->restart_block.fn = do_no_restart_syscall;
   545	
   546		/*
   547		 * Since we stacked the signal on a 128-bit boundary, then 'sp' should
   548		 * be word aligned here.
   549		 */
   550		if (regs->sp & 15)
   551			goto badframe;
   552	
   553		frame = (struct rt_sigframe __user *)regs->sp;
   554	
   555		if (!access_ok(frame, sizeof (*frame)))
   556			goto badframe;
   557	
   558		if (restore_sigframe(regs, frame))
   559			goto badframe;
   560	
   561		if (restore_altstack(&frame->uc.uc_stack))
   562			goto badframe;
   563	
   564		// TODO: memorize the original return PC in setup_rt_frame
   565		// and ensure we are returning to the same PC.
 > 566		if (!__copy_from_user(&info, &sf->info, sizeof(info)) &&
   567			info.si_signo == SIGTRAP && info.si_code == TRAP_PERF &&
   568			info.si_perf_type == PERF_TYPE_BREAKPOINT)
   569			hw_bp_single_step(regs);
   570	
   571		return regs->regs[0];
   572	
   573	badframe:
   574		arm64_notify_segfault(regs->sp);
   575		return 0;
   576	}
   577	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org