| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <Yflt302QEqs5gabI@robh.at.kernel.org>
Date: Tue, 1 Feb 2022 11:29:03 -0600
From: Rob Herring <robh@...nel.org>
To: Corentin Labbe <clabbe@...libre.com>
Cc: jdelvare@...e.com, linux@...ck-us.net, devicetree@...r.kernel.org,
linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] dt-bindings: hwmon: gpio-fan: convert to YAML
On Wed, Jan 26, 2022 at 08:03:50PM +0000, Corentin Labbe wrote:
> Converts hwmon/gpio-fan.txt to YAML
>
> Signed-off-by: Corentin Labbe <clabbe@...libre.com>
> ---
>
> I didnt found any clear maintainer and since DT yaml mandates a
> maintainer section, I set devicetree@...r.kernel.org.
>
> .../devicetree/bindings/hwmon/gpio-fan.txt | 41 --------
> .../devicetree/bindings/hwmon/gpio-fan.yaml | 96 +++++++++++++++++++
> 2 files changed, 96 insertions(+), 41 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/hwmon/gpio-fan.txt
> create mode 100644 Documentation/devicetree/bindings/hwmon/gpio-fan.yaml
>
> diff --git a/Documentation/devicetree/bindings/hwmon/gpio-fan.txt b/Documentation/devicetree/bindings/hwmon/gpio-fan.txt
> deleted file mode 100644
> index f4cfa350f6a1..000000000000
> --- a/Documentation/devicetree/bindings/hwmon/gpio-fan.txt
> +++ /dev/null
> @@ -1,41 +0,0 @@
> -Bindings for fan connected to GPIO lines
> -
> -Required properties:
> -- compatible : "gpio-fan"
> -
> -Optional properties:
> -- gpios: Specifies the pins that map to bits in the control value,
> - ordered MSB-->LSB.
> -- gpio-fan,speed-map: A mapping of possible fan RPM speeds and the
> - control value that should be set to achieve them. This array
> - must have the RPM values in ascending order.
> -- alarm-gpios: This pin going active indicates something is wrong with
> - the fan, and a udev event will be fired.
> -- #cooling-cells: If used as a cooling device, must be <2>
> - Also see:
> - Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
> - min and max states are derived from the speed-map of the fan.
> -
> -Note: At least one the "gpios" or "alarm-gpios" properties must be set.
> -
> -Examples:
> -
> - gpio_fan {
> - compatible = "gpio-fan";
> - gpios = <&gpio1 14 1
> - &gpio1 13 1>;
> - gpio-fan,speed-map = <0 0
> - 3000 1
> - 6000 2>;
> - alarm-gpios = <&gpio1 15 1>;
> - };
> - gpio_fan_cool: gpio_fan {
> - compatible = "gpio-fan";
> - gpios = <&gpio2 14 1
> - &gpio2 13 1>;
> - gpio-fan,speed-map = <0 0>,
> - <3000 1>,
> - <6000 2>;
> - alarm-gpios = <&gpio2 15 1>;
> - #cooling-cells = <2>; /* min followed by max */
> - };
> diff --git a/Documentation/devicetree/bindings/hwmon/gpio-fan.yaml b/Documentation/devicetree/bindings/hwmon/gpio-fan.yaml
> new file mode 100644
> index 000000000000..15bb5efd3cb4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/hwmon/gpio-fan.yaml
> @@ -0,0 +1,96 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/hwmon/gpio-fan.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Bindings for fan connected to GPIO lines
> +
> +maintainers:
> + - OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS <devicetree@...r.kernel.org>
> +
> +properties:
> + compatible:
> + const: gpio-fan
> +
> + gpios:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + description: Specifies the pins that map to bits in the control value,
> + ordered MSB-->LSB.
> +
> + gpio-fan,speed-map:
> + $ref: /schemas/types.yaml#/definitions/uint32-matrix
> + description: A mapping of possible fan RPM speeds and the
> + control value that should be set to achieve them. This array
> + must have the RPM values in ascending order.
> +
> + alarm-gpios:
> + $ref: /schemas/types.yaml#/definitions/phandle-array
> + description: This pin going active indicates something is wrong with
> + the fan, and a udev event will be fired.
> +
> + "#cooling-cells":
> + const: 2
> + description: If used as a cooling device, must be <2>
> + Also see Documentation/devicetree/bindings/thermal/thermal-cooling-devices.yaml
> + min and max states are derived from the speed-map of the fan.
> +
> +anyOf:
> + - required:
> + - gpios
> + - required:
> + - alarm-gpios
> +
> +additionalProperties: False
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/clock/cortina,gemini-clock.h>
> + #include <dt-bindings/reset/cortina,gemini-reset.h>
> + #include <dt-bindings/gpio/gpio.h>
> + gpio1: gpio@...00000 {
> + compatible = "cortina,gemini-gpio", "faraday,ftgpio010";
> + reg = <0x4d000000 0x100>;
> + interrupts = <22 IRQ_TYPE_LEVEL_HIGH>;
> + resets = <&syscon GEMINI_RESET_GPIO0>;
> + clocks = <&syscon GEMINI_CLK_APB>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
No need to show providers in examples.
And one example is probably sufficient here.
> + gpio_fan {
> + compatible = "gpio-fan";
> + gpios = <&gpio1 8 GPIO_ACTIVE_HIGH>;
> + gpio-fan,speed-map = <0 0>,
> + <3000 1>,
> + <6000 2>;
> + alarm-gpios = <&gpio1 15 GPIO_ACTIVE_HIGH>;
> + };
> + - |
> + #include <dt-bindings/interrupt-controller/irq.h>
> + #include <dt-bindings/clock/cortina,gemini-clock.h>
> + #include <dt-bindings/reset/cortina,gemini-reset.h>
> + #include <dt-bindings/gpio/gpio.h>
> + gpio2: gpio@...00000 {
> + compatible = "cortina,gemini-gpio", "faraday,ftgpio010";
> + reg = <0x4d000000 0x100>;
> + interrupts = <22 IRQ_TYPE_LEVEL_HIGH>;
> + resets = <&syscon GEMINI_RESET_GPIO0>;
> + clocks = <&syscon GEMINI_CLK_APB>;
> + gpio-controller;
> + #gpio-cells = <2>;
> + interrupt-controller;
> + #interrupt-cells = <2>;
> + };
> + gpio_fan_cool: gpio_fan {
> + compatible = "gpio-fan";
> + gpios = <&gpio2 8 GPIO_ACTIVE_HIGH
> + &gpio2 1 GPIO_ACTIVE_HIGH>;
> + gpio-fan,speed-map = <0 0
> + 3000 1
> + 6000 2>;
> + alarm-gpios = <&gpio2 15 GPIO_ACTIVE_HIGH>;
> + #cooling-cells = <2>; /* min followed by max */
> + };
> --
> 2.34.1
>
>
Powered by blists - more mailing lists