| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 1 Feb 2022 11:38:05 -0600
From: Rob Herring <robh@...nel.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
Cc: Lee Jones <lee.jones@...aro.org>,
Alim Akhtar <alim.akhtar@...sung.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Sylwester Nawrocki <s.nawrocki@...sung.com>,
Marek Szyprowski <m.szyprowski@...sung.com>,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-serial@...r.kernel.org
Subject: Re: [PATCH 4/5] dt-bindings: mfd: samsung,exynos5433-lpass: Convert
to dtschema
On Sat, Jan 29, 2022 at 06:53:31PM +0100, Krzysztof Kozlowski wrote:
> Convert the Exynos5433 LPASS bindings to DT schema format.
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> ---
> .../bindings/mfd/samsung,exynos5433-lpass.txt | 72 -----------
> .../mfd/samsung,exynos5433-lpass.yaml | 119 ++++++++++++++++++
> 2 files changed, 119 insertions(+), 72 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt
> create mode 100644 Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml
>
> diff --git a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt
> deleted file mode 100644
> index 30ea27c3936d..000000000000
> --- a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.txt
> +++ /dev/null
> @@ -1,72 +0,0 @@
> -Samsung Exynos SoC Low Power Audio Subsystem (LPASS)
> -
> -Required properties:
> -
> - - compatible : "samsung,exynos5433-lpass"
> - - reg : should contain the LPASS top SFR region location
> - and size
> - - clock-names : should contain following required clocks: "sfr0_ctrl"
> - - clocks : should contain clock specifiers of all clocks, which
> - input names have been specified in clock-names
> - property, in same order.
> - - #address-cells : should be 1
> - - #size-cells : should be 1
> - - ranges : must be present
> -
> -Each IP block of the Low Power Audio Subsystem should be specified as
> -an optional sub-node. For "samsung,exynos5433-lpass" compatible this includes:
> -UART, SLIMBUS, PCM, I2S, DMAC, Timers 0...4, VIC, WDT 0...1 devices.
> -
> -Bindings of the sub-nodes are described in:
> - ../serial/samsung_uart.yaml
> - ../sound/samsung-i2s.txt
> - ../dma/arm-pl330.txt
> -
> -
> -Example:
> -
> -audio-subsystem {
> - compatible = "samsung,exynos5433-lpass";
> - reg = <0x11400000 0x100>, <0x11500000 0x08>;
> - clocks = <&cmu_aud CLK_PCLK_SFR0_CTRL>;
> - clock-names = "sfr0_ctrl";
> - #address-cells = <1>;
> - #size-cells = <1>;
> - ranges;
> -
> - adma: adma@...20000 {
> - compatible = "arm,pl330", "arm,primecell";
> - reg = <0x11420000 0x1000>;
> - interrupts = <0 73 0>;
> - clocks = <&cmu_aud CLK_ACLK_DMAC>;
> - clock-names = "apb_pclk";
> - #dma-cells = <1>;
> - #dma-channels = <8>;
> - #dma-requests = <32>;
> - };
> -
> - i2s0: i2s0@...40000 {
> - compatible = "samsung,exynos7-i2s";
> - reg = <0x11440000 0x100>;
> - dmas = <&adma 0 &adma 2>;
> - dma-names = "tx", "rx";
> - interrupts = <0 70 0>;
> - clocks = <&cmu_aud CLK_PCLK_AUD_I2S>,
> - <&cmu_aud CLK_SCLK_AUD_I2S>,
> - <&cmu_aud CLK_SCLK_I2S_BCLK>;
> - clock-names = "iis", "i2s_opclk0", "i2s_opclk1";
> - pinctrl-names = "default";
> - pinctrl-0 = <&i2s0_bus>;
> - };
> -
> - serial_3: serial@...60000 {
> - compatible = "samsung,exynos5433-uart";
> - reg = <0x11460000 0x100>;
> - interrupts = <0 67 0>;
> - clocks = <&cmu_aud CLK_PCLK_AUD_UART>,
> - <&cmu_aud CLK_SCLK_AUD_UART>;
> - clock-names = "uart", "clk_uart_baud0";
> - pinctrl-names = "default";
> - pinctrl-0 = <&uart_aud_bus>;
> - };
> - };
> diff --git a/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml
> new file mode 100644
> index 000000000000..96ef6113c8bf
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/samsung,exynos5433-lpass.yaml
> @@ -0,0 +1,119 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/mfd/samsung,exynos5433-lpass.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Samsung Exynos SoC Low Power Audio Subsystem (LPASS)
> +
> +maintainers:
> + - Krzysztof Kozlowski <krzysztof.kozlowski@...onical.com>
> + - Sylwester Nawrocki <s.nawrocki@...sung.com>
> +
> +properties:
> + compatible:
> + const: samsung,exynos5433-lpass
> +
> + '#address-cells':
> + const: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + items:
> + - const: sfr0_ctrl
> +
> + power-domains:
> + maxItems: 1
> +
> + ranges: true
> +
> + reg:
> + minItems: 2
> + maxItems: 2
> +
> + '#size-cells':
> + const: 1
> +
> +patternProperties:
> + "^dma-controller@[0-9a-f]+$":
> + $ref: /schemas/dma/arm,pl330.yaml
> +
> + "^i2s@[0-9a-f]+$":
> + $ref: /schemas/sound/samsung-i2s.yaml
> +
> + "^serial@[0-9a-f]+$":
> + $ref: /schemas/serial/samsung_uart.yaml
> +
> +required:
> + - compatible
> + - '#address-cells'
> + - clocks
> + - clock-names
> + - ranges
> + - reg
> + - '#size-cells'
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/exynos5433.h>
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + audio-subsystem@...00000 {
> + compatible = "samsung,exynos5433-lpass";
> + reg = <0x11400000 0x100>, <0x11500000 0x08>;
> + clocks = <&cmu_aud CLK_PCLK_SFR0_CTRL>;
> + clock-names = "sfr0_ctrl";
> + power-domains = <&pd_aud>;
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges;
> +
> + dma-controller@...20000 {
> + compatible = "arm,pl330", "arm,primecell";
> + reg = <0x11420000 0x1000>;
> + interrupts = <GIC_SPI 73 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cmu_aud CLK_ACLK_DMAC>;
> + clock-names = "apb_pclk";
> + #dma-cells = <1>;
> + #dma-channels = <8>;
> + #dma-requests = <32>;
> + power-domains = <&pd_aud>;
> + };
> +
> + i2s@...40000 {
> + compatible = "samsung,exynos7-i2s";
> + reg = <0x11440000 0x100>;
> + dmas = <&adma 0>, <&adma 2>;
> + dma-names = "tx", "rx";
> + interrupts = <GIC_SPI 70 IRQ_TYPE_LEVEL_HIGH>;
> + #address-cells = <1>;
> + #size-cells = <0>;
> + clocks = <&cmu_aud CLK_PCLK_AUD_I2S>,
> + <&cmu_aud CLK_SCLK_AUD_I2S>,
> + <&cmu_aud CLK_SCLK_I2S_BCLK>;
> + clock-names = "iis", "i2s_opclk0", "i2s_opclk1";
> + #clock-cells = <1>;
> + pinctrl-names = "default";
> + pinctrl-0 = <&i2s0_bus>;
> + power-domains = <&pd_aud>;
> + #sound-dai-cells = <1>;
> + status = "disabled";
Drop 'status'.
> + };
> +
> + serial@...60000 {
> + compatible = "samsung,exynos5433-uart";
> + reg = <0x11460000 0x100>;
> + interrupts = <GIC_SPI 67 IRQ_TYPE_LEVEL_HIGH>;
> + clocks = <&cmu_aud CLK_PCLK_AUD_UART>,
> + <&cmu_aud CLK_SCLK_AUD_UART>;
> + clock-names = "uart", "clk_uart_baud0";
> + pinctrl-names = "default";
> + pinctrl-0 = <&uart_aud_bus>;
> + power-domains = <&pd_aud>;
> + status = "disabled";
Ditto.
With that,
Reviewed-by: Rob Herring <robh@...nel.org>
Powered by blists - more mailing lists