| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20220201190128.3075065-5-kbusch@kernel.org>
Date: Tue, 1 Feb 2022 11:01:25 -0800
From: Keith Busch <kbusch@...nel.org>
To: linux-nvme@...ts.infradead.org, linux-kernel@...r.kernel.org,
linux-block@...r.kernel.org
Cc: axboe@...nel.dk, hch@....de, martin.petersen@...cle.com,
colyli@...e.de, Keith Busch <kbusch@...nel.org>
Subject: [PATCHv2 4/7] lib: add crc64 tests
Provide a module to test the rocksoft crc64 calculations with well known
inputs and exepected values.
Signed-off-by: Keith Busch <kbusch@...nel.org>
---
v1->v2:
Fixed Kconfig dependency
lib/Kconfig.debug | 4 +++
lib/Makefile | 1 +
lib/test_crc64.c | 68 +++++++++++++++++++++++++++++++++++++++++++++++
3 files changed, 73 insertions(+)
create mode 100644 lib/test_crc64.c
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 14b89aa37c5c..149de11ae903 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -2214,6 +2214,10 @@ config TEST_UUID
config TEST_XARRAY
tristate "Test the XArray code at runtime"
+config TEST_CRC64
+ depends on CRC64
+ tristate "Test the crc64 code at runtime"
+
config TEST_OVERFLOW
tristate "Test check_*_overflow() functions at runtime"
diff --git a/lib/Makefile b/lib/Makefile
index 300f569c626b..e100a4d6a950 100644
--- a/lib/Makefile
+++ b/lib/Makefile
@@ -103,6 +103,7 @@ obj-$(CONFIG_TEST_HMM) += test_hmm.o
obj-$(CONFIG_TEST_FREE_PAGES) += test_free_pages.o
obj-$(CONFIG_KPROBES_SANITY_TEST) += test_kprobes.o
obj-$(CONFIG_TEST_REF_TRACKER) += test_ref_tracker.o
+obj-$(CONFIG_TEST_CRC64) += test_crc64.o
#
# CFLAGS for compiling floating point code inside the kernel. x86/Makefile turns
# off the generation of FPU/SSE* instructions for kernel proper but FPU_FLAGS
diff --git a/lib/test_crc64.c b/lib/test_crc64.c
new file mode 100644
index 000000000000..283fef8f110e
--- /dev/null
+++ b/lib/test_crc64.c
@@ -0,0 +1,68 @@
+// SPDX-License-Identifier: GPL-2.0+
+/*
+ * Tests were selected from NVM Express NVM Command Set Specification 1.0a,
+ * section 5.2.1.3.5 "64b CRC Test Cases" available here:
+ *
+ * https://nvmexpress.org/wp-content/uploads/NVMe-NVM-Command-Set-Specification-1.0a-2021.07.26-Ratified.pdf
+ *
+ * Copyright 2022 Keith Busch <kbusch@...nel.org>
+ */
+
+#include <linux/crc64.h>
+#include <linux/module.h>
+
+static unsigned int tests_passed;
+static unsigned int tests_run;
+
+#define ALL_ZEROS 0x6482D367EB22B64EULL
+#define ALL_FFS 0xC0DDBA7302ECA3ACULL
+#define INC 0x3E729F5F6750449CULL
+#define DEC 0x9A2DF64B8E9E517EULL
+
+static u8 buffer[4096];
+
+#define CRC_CHECK(c, v) do { \
+ tests_run++; \
+ if (c != v) \
+ printk("BUG at %s:%d expected:%llx got:%llx\n", \
+ __func__, __LINE__, v, c); \
+ else \
+ tests_passed++; \
+} while (0)
+
+
+static int crc_tests(void)
+{
+ __u64 crc;
+ int i;
+
+ memset(buffer, 0, sizeof(buffer));
+ crc = crc64_rocksoft(~0ULL, buffer, 4096);
+ CRC_CHECK(crc, ALL_ZEROS);
+
+ memset(buffer, 0xff, sizeof(buffer));
+ crc = crc64_rocksoft(~0ULL, buffer, 4096);
+ CRC_CHECK(crc, ALL_FFS);
+
+ for (i = 0; i < 4096; i++)
+ buffer[i] = i & 0xff;
+ crc = crc64_rocksoft(~0ULL, buffer, 4096);
+ CRC_CHECK(crc, INC);
+
+ for (i = 0; i < 4096; i++)
+ buffer[i] = 0xff - (i & 0xff);
+ crc = crc64_rocksoft(~0ULL, buffer, 4096);
+ CRC_CHECK(crc, DEC);
+
+ printk("CRC64: %u of %u tests passed\n", tests_passed, tests_run);
+ return (tests_run == tests_passed) ? 0 : -EINVAL;
+}
+
+static void crc_exit(void)
+{
+}
+
+module_init(crc_tests);
+module_exit(crc_exit);
+MODULE_AUTHOR("Keith Busch <kbusch@...nel.org>");
+MODULE_LICENSE("GPL");
--
2.25.4
Powered by blists - more mailing lists